prevent out of bound color values in doSetTile_char - #5864
Merged
Conversation
ab9rf
changed the title
doSetTile_chardoSetTile_char
ab9rf
force-pushed
the
pen-color-safety
branch
2 times, most recently
from
August 5, 2026 09:21
5e269db to
04873c1
Compare
some Lua code is leaking a bg of -1 into this function, resulting in an out of bounds reference to `uccolor`. this logic prohibits such out of bound reads the upstream problem still needs to be found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some Lua code is leaking a bg of -1 into this function, resulting in an out of bounds reference to
uccolor. this logic prohibits such out of bound readsthe upstream problem still needs to be foundupstream problem has been found and addressed here