Conversation
Instead of silently swallowing the `tokio::task::spawn_blocking` join error in `verify_async` with `unwrap_or_else`, correctly log the error and use `map_err().ok()?` to propagate it idiomatcally. This addresses task termination safety constraints per codebase requirements.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Remediates unsafe
spawn_blockingtermination inverify_asyncinsideserver_manager/src/core/users.rs. Replaced.unwrap_or_elsewhich hid standardJoinErrors withmap_err()to explicitly report join faults in log before returningNone. Updated audit log inCHANGES-2026-09-13.mdaccordingly. Verification passed all./verify.shbatteries.PR created automatically by Jules for task 12095885245616627147 started by @Cylae