Skip to content

fix: Safely propagate JoinErrors in core/users.rs - #427

Open
Cylae wants to merge 1 commit into
mainfrom
fix-spawn-blocking-unwrap-12095885245616627147
Open

Cylae wants to merge 1 commit into
mainfrom
fix-spawn-blocking-unwrap-12095885245616627147

Conversation

@Cylae

@Cylae Cylae commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Remediates unsafe spawn_blocking termination in verify_async inside server_manager/src/core/users.rs. Replaced .unwrap_or_else which hid standard JoinErrors with map_err() to explicitly report join faults in log before returning None. Updated audit log in CHANGES-2026-09-13.md accordingly. Verification passed all ./verify.sh batteries.


PR created automatically by Jules for task 12095885245616627147 started by @Cylae

Instead of silently swallowing the `tokio::task::spawn_blocking` join error in `verify_async` with `unwrap_or_else`, correctly log the error and use `map_err().ok()?` to propagate it idiomatcally. This addresses task termination safety constraints per codebase requirements.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant