Eliminate test unwraps/expects and prevent bcrypt error swallowing - #426
Conversation
- Removed `unwrap` and `expect` from all `server_manager` test suites to abide by crate-level lint enforcement, leveraging `anyhow::Result` and the `?` operator. - Refactored integration and regression test modules (`integration_tests.rs`, `regression_persistence.rs`) to propagate failures cleanly rather than panic. - Fixed a silent failure in `verify_and_migrate` and `verify_password` within `users.rs` by correctly mapping `bcrypt::verify` results and logging warnings instead of swallowing underlying crate errors into false credential rejections. - Ensured compliance with zero-unwrap code quality rules across `core` logic and verification script pass.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Replaced
unwrapandexpectcalls in tests acrossserver_managerto returnanyhow::Resultand propagate errors using the?operator, adhering to strict crate-level lints. Addressed swallowedbcrypt::verifyerrors by securely logging the underlying failure instead of obscuring it.PR created automatically by Jules for task 6989463041274414938 started by @Cylae