Update to Minecraft 26.3 - #243
Merged
Merged
Conversation
* Replace the removed org.lwjgl.glfw key constants with InputConstants * SlotDisplay.TagSlotDisplay now takes a HolderSet<Item> instead of a TagKey<Item>, and Ingredient#display() wraps plain item sets in it as well, so an actual tag is only recognized via HolderSet#unwrapKey * Level#potionBrewing is gone, brewing reagents are now a recipe property set * Replace the deprecated logoFile with iconFile Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports IntegratedCrafting to Minecraft 26.3 (NeoForge
26.3.0.7-beta).Dependency versions bumped to the 26.3 builds: CyclopsCore
1.30.0-1159, IntegratedDynamics1.33.4-2157, CommonCapabilities2.11.8-398, IntegratedTunnels1.9.6-795. Also bumps the moddev plugin to2.0.147.Changes
org.lwjgl.glfwis goneThe LWJGL GLFW bindings are no longer on the classpath, since input moved to SDL.
GLFW.GLFW_KEY_ESCAPEis replaced byInputConstants.KEY_ESCAPEin the two part screens that handle escape themselves.SlotDisplay.TagSlotDisplaynow holds aHolderSet<Item>Two consequences:
RecipeDeadBush#displayhas to wrap its tag keys viaBuiltInRegistries.ITEM.getOrThrow(...).Ingredient#display()now returns aTagSlotDisplayfor every ingredient, including plain direct item sets. Aninstanceof TagSlotDisplaycheck therefore no longer means "this ingredient is a tag".GameTestHelpersIntegratedCraftingwas readingunwrapKey().get()on it, which threwNoSuchElementExceptionfor any recipe with a non-tag ingredient (5 game tests failed). It now only treats a named holder set as a tag and otherwise falls through to the item-based branch. This matches whatRecipeHandlerHelpersin the CommonCapabilities API already does.Level#potionBrewing()removedBrewing became datapack-driven.
CraftingProcessOverrideBrewingStanddecides per ingredient whether it goes into the reagent slot or a bottle slot; it now askslevel.recipeAccess().propertySet(RecipePropertySet.BREWING_REAGENTS), which is the same source vanilla'sBrewingStandBlockEntity#canPlaceItemuses.logoFiledeprecationneoforge.mods.tomlnow usesiconFile.Validation
./gradlew buildpasses../gradlew runGameTestServer: all 82 required tests pass (5 were failing before theTagSlotDisplayfix).BREWING_REAGENTSon a live server matches the oldisIngredientbehaviour: nether wart / redstone / glowstone dust are reagents, water bottles / glass bottles / cobblestone are not.minecraft:saplingsandc:tools/shear.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Generated by Claude Code