Skip to content

fix(storage): preserve authenticated UUID ownership in CAS mutation workspaces - #1232

Merged
DecisionNerd merged 5 commits into
mainfrom
fix/1228-cas-uuid-mutation-ownership
Sep 10, 2026
Merged

fix(storage): preserve authenticated UUID ownership in CAS mutation workspaces#1232
DecisionNerd merged 5 commits into
mainfrom
fix/1228-cas-uuid-mutation-ownership

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Constructed CAS graphs rejected ordinary and qualified CREATE because hydrated v5 UUID controls had shared inodes, while mutation planning required private ownership. Copy the mutable manifest/receipt through the existing bounded authenticated materializer; keep immutable runs shared only under readonly, retained-identity and digest/block checks. Private construction guards remain strict.

Public regressions cover flat/sharded parents, repeated CREATE/DELETE and surrogate allocation, qualified node/edge ownership, active snapshots, exact reopen/query/export/verify/import, and eight crash/returned-error publication cases. Adversarial tests cover aliases, writable transitions, mutated bytes and path replacement. Exact copy-I/O assertions and deterministic control/allocation budgets accompany source-bound CPU, I/O, RSS and sampled workspace evidence in the assessment.

This repair preserves the shared permanent Parquet policy. Same-name adoption atomicity, bound-composition clear and post-compaction facade refresh remain separate blockers under #1221.

Validation: 54 membership and 38 object-store unit tests; final adversarial authentication test; 733 API unit tests plus the corrected exact-control regression; all 24 public publishing tests; workspace Clippy, formatting, fast pre-push and gate-registry checks. Independent review verified the Windows retained-handle test behavior. The Windows/macOS jobs explicitly run the new shared-run authentication and exact private-control tests. Real 1×/2×/4× lifecycle qualification accounts exact authenticated control bytes before enforcing ordinal-copy bounds, with omitted/excess-work regressions. Workflow lint passed; required exact-head CI remains the merge gate.

Closes #1228

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6210d13f-702d-4670-958a-66f0e1b4af72

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added core Core source code changes documentation Improvements or additions to documentation labels Sep 10, 2026
@github-actions github-actions Bot added the ci-cd CI/CD configuration changes label Sep 10, 2026
@blacksmith-sh

This comment has been minimized.

@DecisionNerd
DecisionNerd merged commit 67412c4 into main Sep 10, 2026
23 checks passed
@DecisionNerd
DecisionNerd deleted the fix/1228-cas-uuid-mutation-ownership branch September 10, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI/CD configuration changes core Core source code changes documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(storage): preserve authenticated UUID ownership in CAS mutation workspaces

1 participant