Repository navigation
test: no per-stack generation smoke test - #58
Merged
AnayDhawan merged 2 commits intoAug 17, 2026
Merged
Conversation
demo/scaffold.sh's fixture is node-only, so no fixture had ever run apply.sh's fill()/command tables against any other stack -- exactly how a real, shipped-since-v1.0.0 crash on every Go repo went unnoticed until it was reported and fixed separately. Adds a smoke_stack loop covering all 11 detected stacks plus generic: writes a bare marker file, runs apply.sh against it with a throwaway config, and asserts a clean exit. Fixes CreativesLibrary#42.
AnayDhawan
approved these changes
Aug 17, 2026
AnayDhawan
left a comment
AnayDhawan
left a comment
Collaborator
There was a problem hiding this comment.
Verified locally: all 12 stacks smoke clean, shellcheck SC2318 fixed. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
tests/run.shandcheck-placeholders.shboth generate throughdemo/scaffold.sh, which hardcodes a node identity. No fixture had ever runfill()/apply.sh against any other stack's command table — exactly how a real, shipped-since-v1.0.0 bug (a crash on every Go repo, since fixed) went unnoticed for this long.Adds a
smoke_stackloop that writes a bare marker file per detected stack (package.json, Cargo.toml, go.mod, ...) into a throwaway$TMPdir and runsapply.shagainst it with a minimal config, asserting a clean exit. Covers all 11 detected stacks plus generic.Closes #42
Type
scripts/) — adds totests/run.shChecklist
shellcheck scripts/*.shpasses (if scripts changed) — not available locally; this PR doesn't touchscripts/, onlytests/run.sh{{PLACEHOLDERS}}, no hardcoded names or pathsVerified locally: full
bash tests/run.shpasses, all 12 stacks (11 detected + generic) run clean.