Repository navigation
fix: apply.sh has no rollback on partial write failure - #57
Merged
AnayDhawan merged 1 commit intoAug 17, 2026
Merged
Conversation
…r generation succeeds A crash mid-generation (a missing template, a fill() failure on some stack's command table) previously left the target repo with whichever files had written before the failure. Because apply.sh never overwrites an existing file, a re-run then skipped the files it did manage to write on the first, partial pass -- a confusing state to land in. Generation now writes into a mktemp staging dir; the target repo is only touched in a final commit loop once every write has already succeeded once. Fixes CreativesLibrary#43.
AnayDhawan
approved these changes
Aug 17, 2026
AnayDhawan
left a comment
AnayDhawan
left a comment
Collaborator
There was a problem hiding this comment.
Verified locally: fixture apply.sh run + full test suite pass. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
apply.sh generated files directly into the target repo.
set -euo pipefailmeans a crash mid-generation (a missing template, a fill() failure) left the target with only whichever files had written before the failure. Because apply.sh never overwrites an existing file, a re-run after a partial failure then skipped the files it did manage to write on the first pass — a confusing state to land in.Generation now writes into a
mktempstaging dir; the target repo is only touched in a final commit loop, once every write has already succeeded once. Either everything lands, or nothing does.Closes #43
Type
scripts/)Checklist
shellcheck scripts/*.shpasses (if scripts changed) — not available locally, CI's shellcheck job will verify{{PLACEHOLDERS}}, no hardcoded names or pathsVerified locally:
bash demo/scaffold.sh init+bash scripts/apply.shagainst the fresh fixture, and fullbash tests/run.shsuite, both pass.