Repository navigation
fix: validate rendered README media in audit - #33
Conversation
|
Looks good, tests pass, will merge once rebased. This now conflicts with main (other PRs landed since you opened it) — could you rebase onto main and force-push? |
|
Thanks so much for digging into the README-media false positive and putting together such a thorough, well-tested fix, contributions like this are exactly what make this project better. If oss-launch has been useful to you, a star on the repo would go a long way in helping more people find it! |
13f36b4 to
de6e439
Compare
|
Rebased this onto current main myself (it had drifted out of a couple other fixes that landed in the meantime, all in the same area of audit.sh/tests/run.sh) and reran the full local suite plus CI, both clean. Solid fix, appreciated the regression fixtures for the raw-text false positive, the failure-marker mismatch, and the provider-agnostic badge case, exactly the kind of coverage that keeps this from regressing quietly. Merging. |
What and why
Closes #32.
audit.shcurrently scans raw README text, so words inside comments or fenced examples can incorrectly satisfy the demo check. It also misses valid image-based badges from providers outside its small hostname list, and prints a warning marker for a scored badge failure.This change:
Type
templates/)scripts/)references/,SKILL.md)Testing
docker run --rm --network none -v "$PWD:/repo:ro" -w /repo bash:5.2 bash tests/run.sh— all audit fixtures pass, including the full16/16case.git ls-files -z 'scripts/*.sh' 'tests/*.sh' 'demo/*.sh' | xargs -0 shellcheck— passes.The full suite was run in Linux Bash 5.2, matching CI. Some existing fixture helpers use GNU
sedsyntax and do not run correctly with macOS BSDsed; this patch does not change those helpers.Checklist
shellcheck scripts/*.shpasses (if scripts changed){{PLACEHOLDERS}}, no hardcoded names or paths (templates are untouched)