fix(proof-harvest): no proxy tar leak on missing holdout shard - #237
Merged
Conversation
Greptile SummarySummary
Confidence Score: 5/5Safe to merge. There are no outstanding findings. Reviews (2): Last reviewed commit: "fix(proof-harvest): case-insensitive lef..." | Re-trigger Greptile |
Isolate leftover-tar scans to a per-test staging dir so concurrent pack_helpers/score tests cannot false-fail the holdout refuse checks. Name proxy tars with a process-wide seq so concurrent packs cannot clobber the same /tmp path. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Co-authored-by: Mathis <echobt@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-proof-harvest-proxy-tar-leak-9018
branch
from
September 8, 2026 10:25
2417b06 to
4873539
Compare
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
main(#235 /8b39d24f) failedtests::missing_holdout_shard_does_not_leak_a_proxy_tarwhile the siblinglive_extras_holdout_refuse_does_not_leak_a_proxy_tarpassed.Holdout-first packing in
live_extrasis already correct: a missing/mismatched shard returnsHoldoutStoreMissingbeforepack_proxy_tar_to, so that refuse path does not create a proxy tar. The CI failure was a leftover-scan race: leak tests listed/tmp/proof-proxy-{pid}-*.tar, and a concurrent unit test (pack_helpers_succeed_on_operator_staged_trees/ a livescore()pack) still held a tar in the same process temp dir.This PR:
/tmppath.live_extraswrites into the configured dir andProxyTarGuarddeletes it on drop.Does not change StubWin,
FORCE_SIM, pins, overlays, or eval digests.Greptile
Every PR is reviewed by Greptile before merge. Config:
.greptile/.@greptileai reviewTest plan
cargo test -p proof-harvest --lib(both leak tests + guard test; 10 repeats of the leak tests)cargo clippy -p proof-harvest --all-targets -- -D warningscargo run -p xtask -- loc-capcargo fmt --all -- --check(formattedproof-harvest; workspace fmt not re-run)Risk
Test isolation + unique tar names on the harvest control plane only. No deploy, miner CVM, signature domain, or emission impact.
Naming
I did not rename
BASE_*environment variables, deployed host paths(
/opt/base,/run/base, …), GHCRbaseintelligence/basepackage names, orbase-*-v1cryptographic domain tags, unless this PR’s purpose is a coordinatedcutover documented in
docs/NAMING.md.