Repository navigation
feat(lstsv): map appearance horizontal to the bootstrap_buttons question theme - #229
Merged
Merged
Conversation
…ion theme (#227) horizontal and horizontal-compact on select_one use the registry's lsQuestionTheme (#232): question_theme_name=bootstrap_buttons. The way back reads the first registered appearance of a theme, horizontal. A theme that doesn't override the type is kept only on a plain list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jstet
force-pushed
the
feat/horizontal-buttons-227
branch
from
November 4, 2026 18:59
09bf158 to
42118de
Compare
jstet
marked this pull request as ready for review
November 4, 2026 19:01
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227.
appearance: horizontalandhorizontal-compacton aselect_oneset LimeSurvey's core question themebootstrap_buttons(Q-row columnquestion_theme_name, type staysL), so a short list renders as a row of buttons. Built on #232's mechanism: both registry entries carrylsQuestionTheme: {"name": "bootstrap_buttons"}; no new schema field or code path for the mapping itself. DDI is unchanged and keeps the appearance.Two small points beyond the registry entries:
themedAppearanceOfmatches both appearances (same theme). It returns the first registered one, sobootstrap_buttonscomes back ashorizontal;horizontal-compactis registered after it. No extra field was needed; a test pins this.themeAttributesnow takes the LimeSurvey type and keeps a theme that doesn't override the type (bootstrap_buttons) only on a plain list. Without itminimal horizontalwould emit a!question with the buttons theme.Not included:
columns/columns-n→display_columns; a follow-up.Before / After
select_one yn+horizontalLwithquestion_theme_name=bootstrap_buttonsbootstrap_buttonsonLappearance: horizontalTests
New
tests/ts/unit/horizontalButtons.test.ts(6 tests: both appearances, no column when unused,minimalprecedence, select_multiple warns, round trip).appearance.test.tsnow uses another unsupported appearance.npm test: 1765 passed (108 files);npm run validateclean.🤖 Generated with Claude Code