Repository navigation
fix(extract): the tracker layout finding names its columns - #39
Open
TatianaTchouakam wants to merge 1 commit into
Open
TatianaTchouakam wants to merge 1 commit into
TatianaTchouakam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 13.
tracker_layout_changednamed its column only in the message ("Column AD does not mean the same thing..."); thecolumnfield was empty, so filtering the findings by column did not find it. The emitter already had the pipeline column names (change.canonical); they are now passed ascolumn, joined by ", ", as other findings use pipeline names in that field.sheet_namestays empty: the finding compares the month sheets (scopetracker_column).Effect (full local run,
--skip-upload):tracker_layout_changedNo finding count changed, by type and year.
Tests: full suite 1,399 passed. No new unit test: the finding is emitted while reading a whole workbook, and the existing tests of
read_all_patient_sheetsneed real tracker files; the full local run above is the check.