Skip to content

fix(extract): the tracker layout finding names its columns - #39

Open
TatianaTchouakam wants to merge 1 commit into
devfrom
fix/layout-finding-names-column
Open

TatianaTchouakam wants to merge 1 commit into
devfrom
fix/layout-finding-names-column

Conversation

@TatianaTchouakam

Copy link
Copy Markdown
Collaborator

Ticket 13.

tracker_layout_changed named its column only in the message ("Column AD does not mean the same thing..."); the column field was empty, so filtering the findings by column did not find it. The emitter already had the pipeline column names (change.canonical); they are now passed as column, joined by ", ", as other findings use pipeline names in that field. sheet_name stays empty: the finding compares the month sheets (scope tracker_column).

Effect (full local run, --skip-upload):

Before After
All findings 70,913 70,913
tracker_layout_changed 257 (column empty) 257 (column filled in 257)

No finding count changed, by type and year.

Tests: full suite 1,399 passed. No new unit test: the finding is emitted while reading a whole workbook, and the existing tests of read_all_patient_sheets need real tracker files; the full local run above is the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants