Repository navigation
fix(clean): absence words in product units received give no type_conversion finding - #38
Open
TatianaTchouakam wants to merge 1 commit into
Open
TatianaTchouakam wants to merge 1 commit into
TatianaTchouakam wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 6.
product_units_receivedis cast in_clean_units_received, which did not use the shared list of absence words (MISSING_VALUE_MARKERS) used by the patient and date paths. A cell reading "na" was reported as atype_conversionfinding, then published as 0 by the next step (_recode_na_units_to_zero).Change: an absence word in
product_units_receivedis no longer reported. The published value does not change: it is still 0 (nothing received).Effect (full local run,
--skip-upload):type_conversionThe 12 findings were all in 2018 trackers, 0 in 2026. No other finding type changed, compared by year and column.
Tests: new test
test_units_received_absence_word_gives_no_finding(fails without the change); full suite 1,400 passed.