Skip to content

fix(clean): absence words in product units received give no type_conversion finding - #38

Open
TatianaTchouakam wants to merge 1 commit into
devfrom
fix/product-units-absence-markers
Open

TatianaTchouakam wants to merge 1 commit into
devfrom
fix/product-units-absence-markers

Conversation

@TatianaTchouakam

Copy link
Copy Markdown
Collaborator

Ticket 6.

product_units_received is cast in _clean_units_received, which did not use the shared list of absence words (MISSING_VALUE_MARKERS) used by the patient and date paths. A cell reading "na" was reported as a type_conversion finding, then published as 0 by the next step (_recode_na_units_to_zero).

Change: an absence word in product_units_received is no longer reported. The published value does not change: it is still 0 (nothing received).

Effect (full local run, --skip-upload):

Before After
All findings 70,913 70,901
type_conversion 19,314 19,302

The 12 findings were all in 2018 trackers, 0 in 2026. No other finding type changed, compared by year and column.

Tests: new test test_units_received_absence_word_gives_no_finding (fails without the change); full suite 1,400 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant