Repository navigation
fix(clean): no formula error finding when the formula's inputs are blank - #25
Merged
Merged
Conversation
TatianaTchouakam
changed the base branch from
dev
to
feat/ticket-6-missing-words-empty
October 23, 2026 10:26
pmayd
approved these changes
Oct 27, 2026
pmayd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, please use a squash commit
TatianaTchouakam
force-pushed
the
feat/formula-error-empty-sources
branch
from
October 27, 2026 15:58
90ed3ec to
f7d8227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #24: both add tests at the end of
test_converters.py. When #24 is merged, this PR will point todev.When a computed field has an Excel error, the source fields of the same row are now checked. If a source field is empty, no finding is reported.
Already in the code
normalize_excel_formula_errors(clean/converters.py, ticket 27) turns Excel errors (#DIV/0!,#NUM!…) into empty cells and reports onesource_formula_errorper cell.Findings
source_formula_errorare in 2 columns:t1d_diagnosis_age(11,001) andbmi(5,557).Changes
FORMULA_INPUTS:bmicomes fromweightandheight;t1d_diagnosis_agefromdobandt1d_diagnosis_date._formula_input_missing(): true when one of these inputs is in the frame and blank on the row (null, empty, or aMISSING_VALUE_MARKERSvalue such as-).fbg_baseline_mg,age, stock) are not changed.Tests
-→ no finding; with both recorded → finding (invented data).just cigreen, golden unchanged.Result (local run, no upload)
t1d_diagnosis_agebmifbg_baseline_mgageproduct_entry_datebmiandt1d_diagnosis_agehave their inputs recorded: real formula problems, still reported.Open point
The missing measurements are no longer reported here. If useful for the clinics, they could be reported once as a missing value in a separate PR.