Skip to content

feat(findings): report each testing frequency range (ticket 4, part 2) - #23

Merged
TatianaTchouakam merged 1 commit into
devfrom
feat/ticket-4-testing-frequency-findings
Oct 27, 2026
Merged

TatianaTchouakam merged 1 commit into
devfrom
feat/ticket-4-testing-frequency-findings

Conversation

@TatianaTchouakam

@TatianaTchouakam TatianaTchouakam commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

This PR is the second part of ticket 4 (testing frequency). It is based on #22 (blood pressure), because both change the same lines in findings.py. When #22 is merged, this PR will point to dev.

Before, when a clinic wrote a range like "3-4", the pipeline published the mean (3.5) and created only one finding per tracker, without the sheet, the patient or the value.

Now there is one finding per cell, with the sheet, the patient, the value the clinic wrote and the mean that was published. The published value does not change.

Changes:

  • fix_testing_frequency: one finding per range, the same way as for blood pressure
  • findings.py: the scope is now row instead of tracker_column
  • function_name="convert_testing_frequency" kept for the taxonomy test

Tests:

  • one new test (invented data): one finding per range, nothing for a single number or an empty cell
  • sheet_name column added to 5 existing tests with a range
  • just ci is green

Result (local run, no upload):

  • testing_frequency_averaged: 10 → 479. Same cases, now one per cell. It stays in "recovered", so "needs action" does not change.
  • 2026: 0
  • All finding types compared by year: nothing else changed.

@pmayd pmayd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, use a squash merge commit :)

@TatianaTchouakam
TatianaTchouakam force-pushed the feat/ticket-4-testing-frequency-findings branch from c610a12 to dfa6e4e Compare October 27, 2026 15:53
@TatianaTchouakam
TatianaTchouakam merged commit f1432d3 into dev Oct 27, 2026
2 checks passed
@TatianaTchouakam
TatianaTchouakam deleted the feat/ticket-4-testing-frequency-findings branch October 27, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants