Repository navigation
feat(findings): report each testing frequency range (ticket 4, part 2) - #23
Merged
Merged
Conversation
pmayd
approved these changes
Oct 27, 2026
pmayd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, use a squash merge commit :)
…nt and value (ticket 4)
TatianaTchouakam
force-pushed
the
feat/ticket-4-testing-frequency-findings
branch
from
October 27, 2026 15:53
c610a12 to
dfa6e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the second part of ticket 4 (testing frequency). It is based on #22 (blood pressure), because both change the same lines in
findings.py. When #22 is merged, this PR will point todev.Before, when a clinic wrote a range like "3-4", the pipeline published the mean (3.5) and created only one finding per tracker, without the sheet, the patient or the value.
Now there is one finding per cell, with the sheet, the patient, the value the clinic wrote and the mean that was published. The published value does not change.
Changes:
fix_testing_frequency: one finding per range, the same way as for blood pressurefindings.py: the scope is nowrowinstead oftracker_columnfunction_name="convert_testing_frequency"kept for the taxonomy testTests:
sheet_namecolumn added to 5 existing tests with a rangejust ciis greenResult (local run, no upload):
testing_frequency_averaged: 10 → 479. Same cases, now one per cell. It stays in "recovered", so "needs action" does not change.