Skip to content

feat(diagnostics): add strict writing diagnostic contract - #249

Draft
seonghobae wants to merge 24 commits into
design/llm-writing-diagnosticsfrom
feat/writing-diagnostics-contract
Draft

feat(diagnostics): add strict writing diagnostic contract#249
seonghobae wants to merge 24 commits into
design/llm-writing-diagnosticsfrom
feat/writing-diagnostics-contract

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Scope

Stacked Task 1 implementation lane for PR #248's writing-diagnostics plan. The PR remains Draft and targets design/llm-writing-diagnostics; #248 is the governing dependency-root authority.

Current exact stack authority

The branch was synchronized non-destructively through a two-parent commit over the exact current #248 tree. Fresh comparison resolves merge base to exact parent, reports behind_by=0, and leaves exactly this lane's seven paths changed. No force push or destructive rebase was used.

Test-first behavior

The contract was developed RED→GREEN before production implementation and provides provider-neutral diagnostics/provenance types, bounded priorities/resources/strings/selectors, exact own-data-property validation, hostile-reflection rejection, duplicate-ID rejection, exact revision/projection binding, deeply detached/frozen accepted values, stable redacted failures, and root plus React-free exports.

It performs no semantic language judgment, keyword/regex/phrase fallback, model/provider/network/database/credential access, stale-text repair, decoration, document mutation or send gate.

Exact-current-head evidence

Current exact head e80545e6a85b628d624f43d60259f16c6b2244d6 has no qualifying current-head PR workflow runs returned by the live workflow-run query yet. Therefore predecessor focused TDD success is historical only and current-head CI/security/SAST/package/browser/coverage evidence remains non-passing until freshly produced. Formal submitted reviews and unresolved inline threads are currently zero.

Remaining gates

Do not self-approve, transfer predecessor evidence, weaken gates, bypass dependency order or synthesize release identity.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: afb9cb5b-198c-4ff7-b221-8d99f15ab443

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant