feat(diagnostics): add strict writing diagnostic contract - #249
Draft
seonghobae wants to merge 24 commits into
Draft
feat(diagnostics): add strict writing diagnostic contract#249seonghobae wants to merge 24 commits into
seonghobae wants to merge 24 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 16, 2026
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked Task 1 implementation lane for PR #248's writing-diagnostics plan. The PR remains Draft and targets
design/llm-writing-diagnostics; #248 is the governing dependency-root authority.Current exact stack authority
design/llm-writing-diagnostics@f97d9d6787fd0d6c01bd245506e8a220af8a8a5a;e80545e6a85b628d624f43d60259f16c6b2244d6;The branch was synchronized non-destructively through a two-parent commit over the exact current #248 tree. Fresh comparison resolves merge base to exact parent, reports
behind_by=0, and leaves exactly this lane's seven paths changed. No force push or destructive rebase was used.Test-first behavior
The contract was developed RED→GREEN before production implementation and provides provider-neutral diagnostics/provenance types, bounded priorities/resources/strings/selectors, exact own-data-property validation, hostile-reflection rejection, duplicate-ID rejection, exact revision/projection binding, deeply detached/frozen accepted values, stable redacted failures, and root plus React-free exports.
It performs no semantic language judgment, keyword/regex/phrase fallback, model/provider/network/database/credential access, stale-text repair, decoration, document mutation or send gate.
Exact-current-head evidence
Current exact head
e80545e6a85b628d624f43d60259f16c6b2244d6has no qualifying current-head PR workflow runs returned by the live workflow-run query yet. Therefore predecessor focused TDD success is historical only and current-head CI/security/SAST/package/browser/coverage evidence remains non-passing until freshly produced. Formal submitted reviews and unresolved inline threads are currently zero.Remaining gates
main@3b38ead2d00f44eb578d0689087b9293b3dabe1e.Do not self-approve, transfer predecessor evidence, weaken gates, bypass dependency order or synthesize release identity.