fix(workspace): keep unmatched focus labels from selling a no-op

[cursor]

Closed as proven duplicate of canonical #874

Exact evidence before closure:

• fix(workspace): keep unmatched focus labels from selling a no-op #880 exact head a0c2e61239aa1a24d33b5d2a3529ee4c73daecd9 and the incorporated fix(workspace): keep unmatched focus labels from selling a no-op #882/feat(workspace): name the parts to lock in first #874 head 43cb9438d6338890a218f2d3b7c4ba74199adb00 are sibling commits with the same parent c646037d390ed92dfe12c4416e8eb9874cc03b6b.
• Both commit objects resolve to the identical Git tree 1e75a42393589644ebcf97cab7e0b193c82c9ad4; the different commit SHAs reflect commit metadata, not a semantic/file delta.
• Canonical feat(workspace): name the parts to lock in first #874 has already been fast-forwarded without force to 43cb9438…, therefore it now owns the exact same tree and all fix(workspace): keep unmatched focus labels from selling a no-op #880 behavior.
• The stale fix(workspace): keep unmatched focus labels from selling a no-op #880 body claim that it targeted main is also superseded by live metadata: the PR actually targets protected develop.

No checks/reviews transfer from this duplicate. Canonical #874 must use fresh exact-head evidence only.

[cursor]

Stale comment

Base-branch correction needed

open_git_pr opened this against main. Gitflow requires develop (acdbea63). Retarget the base to develop before treating this as the lock-in landing vehicle.

This head (a0c2e612) includes #877 plus unmatched-focus honesty and roadmap scrollIntoView. Prefer it over #877 and #874 once the base is develop.

Do not treat this comment as approval. Exact-head CI and an independent non-author last-push review are still required. Do not mix stem-lane work here.

View PR

  

_{Sent by Cursor Automation: Fix Issues}

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[cursor]

Stale comment

Review (head a0c2e612, base now develop)

This PR was opened against main, which produced a 230-file false tree. It is now retargeted to develop@acdbea63. The real diff is 10 files (+764/-10) and matches the lock-in residual that #877 left open.

Verified on the develop diff:

• Unmatched focus labels are omitted, so a missing bridge cannot be sold as a roadmap action.
• handleFocusSectionActivate only writes a section id when a card matches; it no longer assigns null and wipe verse focus.
• Blank/none first-section sentinels fall through to a real entrance.
• Lock-in pair and focus-label clicks mark aria-current and call scrollIntoView.
• Late Night Set high-priority pairs, repeated-verse third slot, and ko+en empty copy stay honest.
• Storybook inventory is Workspace/Rehearsal Priorities.

No Critical findings on this head. GitHub blocks same-actor approval, so this is COMMENT only. Prefer this over #874. #877 is closed. Do not mix stem-lane placeholder work onto this head. Merge only after exact-head CI on a0c2e612 and an independent non-author approval.

View PR

  

_{Sent by Cursor Automation: Fix Issues}

[cursor]

Stale comment

Review at a0c2e612

The residual fix itself is the right slice: omit unmatched focus labels, skip none first-section sentinels, and scroll the named roadmap card into view.

Do not merge #880. The Gitflow base is main, so the published diff is not the lock-in residual. Landing vehicle is #882 43cb9438 vs develop@acdbea63 (same residual on the protected develop tip). Prefer #882 over #880 and #874.

Do not open a third residual-fix PR. Do not mix stem-lane work onto this slice. Do not self-approve.

View PR

  

_{Sent by Cursor Automation: Fix Issues}

[cursor]

Review at a0c2e612 vs develop@acdbea63

Base is develop. Earlier notes that preferred #882 because this PR targeted main are stale. #880 is the lock-in landing vehicle. Prefer it over draft #882 (43cb9438) and draft #874 (c646037d). #877 is closed. Do not open a third residual-fix PR. Do not mix stem-lane or #776 work onto this head.

Verified on the develop diff (10 files, +764/−10):

• collectFocusSectionLabels omits a label unless findSectionIdForFocusLabel returns an id, so focusSections: ["verse", "bridge"] shows only verse.
• handleFocusSectionActivate writes only inside if (sectionId) and cannot assign null or wipe verse focus.
• Blank/none/NONE sentinels are skipped for lock-in names, focus labels, and the first-section fallback.
• Lock-in pairs de-dupe by display text and role.id:section.id. Late Night Set stays Bass Guitar · verse and Keyboard 1 Right Hand · verse; a repeated verse leaves the third slot as Lead Vocal · chorus.
• Named roadmap cards get aria-current="true" and scrollIntoView.
• ko+en empty copy points at the section roadmap. Untrusted strings render as React text nodes only. No new file, URL, subprocess, IPC, WebView, model, database, or dependency path.

No Critical or Important findings on this head.

Follow-ups after merge, not this slice: assert queryByText("bridge") in the omit test; honor prefers-reduced-motion on roadmap scroll; replace sequential .replace in aria-labels with the single-pass interpolator #744 already owns.

This comment is not approval. GitHub blocks same-actor approval. Merge only after exact-head CI on a0c2e612 and a qualifying independent non-author last-push review.

  

_{Sent by Cursor Automation: Fix Issues}