Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ARCHITECTURE.md

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ All notable changes to TEPP are documented here. The format follows Keep a Chang

## [Unreleased]

- `psychometric_core` recovers the Driver, Oud, and Voelkle (2017, p. 16 `discreteTDPREDEFFECTstd`; Eq. 3, p. 4; Table 2, p. 12; footnote 4; §7.2, pp. 20–22; 2017-era ctsem `summary.ctsemFit.R`; JSS PDF re-opened 2026-08-31T03:08Z from https://www.jstatsoft.org/index.php/jss/article/download/v077i05/1104) scalar standardised discrete time-dependent predictor effect on current main as an independent successor of queued unstandardised `discreteTDPREDEFFECT` (#336). Page 16 prints discrete-time transformations for a chosen event interval and, when appropriate, standardised matrices with the suffix `std`. Footnote 4 standardises using only the relevant variance, not the total. Table 2 names `M` `TDPREDEFFECT` and names `TDPREDVAR` the time-dependent predictor variance. The 2017-era source (cran 2.5.0) forms `discreteDRIFT` as `OpenMx::expm(DRIFT * timeInterval)` and forms continuous `TDPREDEFFECT`; it does not form a `discreteTDPREDEFFECT` or `discreteTDPREDEFFECTstd` matrix, and it comments out `TDPREDVAR` / `TDPREDVARstd`. Page 22 does not report standardised TDPRED estimates because that example assumes no model for the predictor variance. The scalar map is the footnote 4 standardisation of the named discrete coefficient `e^{A Δt} M` after strictly positive `asymDIFFUSION` `p = −q / (2 a)` and strictly positive `TDPREDVAR` `v`: `e^{a Δt} m · √v / √p`. Form strictly positive `p` first, then strictly positive `v`, then the discrete coefficient, then the SD ratio. A zero coefficient is exactly zero after those positive SDs. Unstandardised `e^{a Δt} m` is defined for growing `a ≥ 0` and for zero diffusion; standardised discrete TDPRED is not. Zero `q` has no positive process SD and fails closed. Zero `v` has no positive predictor SD and fails closed. Lasting `p` requires stable `a < 0`. A non-event clock fails closed. A non-positive event interval fails closed. Binary64 underflow of `e^{a Δt}` to `+0` is a vanishing discrete coefficient and is kept. `m · √v / √p` is `TDPREDEFFECTstd` and does not depend on `Δt`. `e^{a Δt}` is `discreteDRIFTstd` after the scalar stationary SD ratio of 1 and is not this map. `A^{-1}[e^{A Δt} − I] M · √v / √p` is discreteCINT arithmetic on `M` and is not this map. `e^{a Δt} m · √v / √(trait + p + added)` uses the total and is not this residual map. Meredith (1993) remains unread. Mislevy (1991, *Psychometrika, 56*, 177–196) remains unread. Still not a Kalman filter, not a matrix `expm`, not ESEM estimation, not DSEM, and not ctsem estimation.
- Removed the repository-local hourly PR-maintenance caller now covered by the central required scheduler, retired stale workflow registrations, narrowed documentation triggers, keyed PR concurrency by fixed workflow name, repository, and pull-request number without cancelling non-PR runs, and combined line/branch coverage on one sequential runner while preserving both 100% gates and diagnostics.

- `event_core` adds bounded Allen interval-consistency classification, atomic path-consistency closure, contradiction/resource refusals, and an explicit dependency-error fallback without claiming unrestricted global satisfiability.
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md

Large diffs are not rendered by default.

91 changes: 91 additions & 0 deletions crates/psychometric_core/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,37 @@ pub enum PsychometricError {
/// `MANIFESTVARstd`. `λ² Var(η) + θ` is `Var(y)`, not the
/// correlation form of `Θ`.
ObservedVarianceIsNotStandardisedManifestVariance,
/// Footnote-4 `discreteTDPREDEFFECTstd` was requested without a
/// strictly positive `asymDIFFUSION`. Footnote 4 standardises
/// using only the relevant variance; zero `q` has no positive
/// process SD.
StandardisedDiscreteTimeDependentPredictorEffectRequiresPositiveStationaryVariance,
/// Footnote-4 `discreteTDPREDEFFECTstd` was requested without a
/// strictly positive time-dependent predictor variance. Page 22
/// does not form standardised TDPRED estimates when there is no
/// model for that variance; zero `v` has no positive predictor SD.
StandardisedDiscreteTimeDependentPredictorEffectRequiresPositivePredictorVariance,
/// Unstandardised remaining impulse `e^{a Δt} m` was treated as
/// `discreteTDPREDEFFECTstd`. Unstandardised `e^{a Δt} m` is
/// defined for growing `a ≥ 0` and for zero diffusion;
/// standardised discrete TDPRED is not.
UnstandardisedDiscreteTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect,
/// Footnote-4 `TDPREDEFFECTstd` `m · √v / √p` was treated as
/// `discreteTDPREDEFFECTstd`. The continuous std does not depend
/// on the event interval.
StandardisedTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect,
/// `discreteDRIFTstd` `e^{a Δt}` was treated as
/// `discreteTDPREDEFFECTstd`. The auto-effect is not
/// `e^{a Δt} m · √v / √p`.
StandardisedDiscreteDriftIsNotStandardisedDiscreteTimeDependentPredictorEffect,
/// Intercept-style `A^{-1}[e^{A Δt} − I] M · √v / √p` was treated
/// as `discreteTDPREDEFFECTstd`. That is discreteCINT arithmetic
/// on `M`.
InterceptStyleStandardisedTimeDependentEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect,
/// `e^{a Δt} m · √v / √(trait + p + added)` was treated as
/// `discreteTDPREDEFFECTstd`. Footnote 4 uses `asymDIFFUSION`,
/// not the total.
TraitScaledDiscreteTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect,
}

impl fmt::Display for PsychometricError {
Expand Down Expand Up @@ -1235,6 +1266,27 @@ impl fmt::Display for PsychometricError {
Self::ObservedVarianceIsNotStandardisedManifestVariance => {
"observed-indicator variance is not standardised measurement-error variance"
}
Self::StandardisedDiscreteTimeDependentPredictorEffectRequiresPositiveStationaryVariance => {
"standardised discrete time-dependent predictor effect requires strictly positive stationary within-subject variance"
}
Self::StandardisedDiscreteTimeDependentPredictorEffectRequiresPositivePredictorVariance => {
"standardised discrete time-dependent predictor effect requires strictly positive time-dependent predictor variance"
}
Self::UnstandardisedDiscreteTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect => {
"unstandardised discrete time-dependent predictor effect is not standardised discrete time-dependent predictor effect"
}
Self::StandardisedTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect => {
"standardised time-dependent predictor effect is not standardised discrete time-dependent predictor effect"
}
Self::StandardisedDiscreteDriftIsNotStandardisedDiscreteTimeDependentPredictorEffect => {
"standardised discrete drift is not standardised discrete time-dependent predictor effect"
}
Self::InterceptStyleStandardisedTimeDependentEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect => {
"intercept-style standardised time-dependent effect is not standardised discrete time-dependent predictor effect"
}
Self::TraitScaledDiscreteTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect => {
"trait-scaled discrete time-dependent predictor effect is not standardised discrete time-dependent predictor effect"
}
};
formatter.write_str(message)
}
Expand Down Expand Up @@ -2073,4 +2125,43 @@ mod tests {
"measurement error is not standardised manifest-trait variance"
);
}

#[test]
fn standardised_discrete_time_dependent_predictor_effect_boundary_messages_are_stable() {
assert_eq!(
PsychometricError::StandardisedDiscreteTimeDependentPredictorEffectRequiresPositiveStationaryVariance
.to_string(),
"standardised discrete time-dependent predictor effect requires strictly positive stationary within-subject variance"
);
assert_eq!(
PsychometricError::StandardisedDiscreteTimeDependentPredictorEffectRequiresPositivePredictorVariance
.to_string(),
"standardised discrete time-dependent predictor effect requires strictly positive time-dependent predictor variance"
);
assert_eq!(
PsychometricError::UnstandardisedDiscreteTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect
.to_string(),
"unstandardised discrete time-dependent predictor effect is not standardised discrete time-dependent predictor effect"
);
assert_eq!(
PsychometricError::StandardisedTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect
.to_string(),
"standardised time-dependent predictor effect is not standardised discrete time-dependent predictor effect"
);
assert_eq!(
PsychometricError::StandardisedDiscreteDriftIsNotStandardisedDiscreteTimeDependentPredictorEffect
.to_string(),
"standardised discrete drift is not standardised discrete time-dependent predictor effect"
);
assert_eq!(
PsychometricError::InterceptStyleStandardisedTimeDependentEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect
.to_string(),
"intercept-style standardised time-dependent effect is not standardised discrete time-dependent predictor effect"
);
assert_eq!(
PsychometricError::TraitScaledDiscreteTimeDependentPredictorEffectIsNotStandardisedDiscreteTimeDependentPredictorEffect
.to_string(),
"trait-scaled discrete time-dependent predictor effect is not standardised discrete time-dependent predictor effect"
);
}
}
Loading
Loading