Skip to content

docs: correct runtime attribution and record coverage evidence - #984

Draft
seonghobae wants to merge 143 commits into
codex/e2e-auth-redirect-main-20260908from
codex/gap-baseline-20260908
Draft

seonghobae wants to merge 143 commits into
codex/e2e-auth-redirect-main-20260908from
codex/gap-baseline-20260908

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Current stack authority — 2026-09-23 KST

#983 advanced test-only to ca593487... with a bounded Ask transport-failure regression: network rejection must render the existing service-unreachable message, must not leak the underlying socket detail, and must not retry implicitly. Production transport behavior, coverage configuration, and thresholds are unchanged.

This branch was converged immediately with an ordinary two-parent commit and a non-force ref update. Fresh compare against product parent ca593487... has merge-base exactly at that parent and behind_by=0. Effective child files remain only AGENTS.md and docs/product-technical-gap-baseline.md; the current parent AskAgentPanel.test.tsx blob is inherited rather than reimplemented.

Descendant #992 is converged on this exact head at e3a193c4512a057873271b101c341ffe1f80982a; its effective delta remains the gap baseline plus documentation-hygiene test.

Predecessor validation receipts do not transfer. Keep Draft; this lane is not an acceptance substitute for #983's repository-wide 100% coverage repair, full suite, Security/SAST/Required CodeQL, browser/a11y evidence, independent approval, or release evidence.

No force push, destructive rebase, parent repair copy, gate weakening, merge, or release is authorized.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

📝 Walkthrough

Walkthrough

로컬 엔드포인트 측정 규칙과 시스템 관측 결과를 추가했습니다. UI, API, mock, 커버리지, 숫자 지수 렌더링의 검증 결과와 테스트 진단 기준도 기록했습니다.

Changes

런타임 측정 및 검증

Layer / File(s) Summary
측정 규칙과 시스템 관측
AGENTS.md, docs/product-technical-gap-baseline.md
서비스 포트, 요청·실패·타임아웃 기록, 측정 범위, CPU 및 pressure 지표 규칙을 정의했습니다. 컨테이너 내부와 호스트의 지연 및 실행 결과를 기록했습니다.
UI 및 API 검증 기준
AGENTS.md, docs/product-technical-gap-baseline.md
Storybook 키보드 검증, API URL 계약, 성공 응답 디코딩, 4xx 오류 처리, 대시보드 검증 결과를 기록했습니다.
테스트 격리와 커버리지 진단
AGENTS.md, docs/product-technical-gap-baseline.md
mock 리셋, 실패 시 커버리지 보고서 보존, worker 시작 오류, 테스트 분모, PostgreSQL 및 호스티드 실행 결과를 기록했습니다.
수량 지수 렌더링 검증
AGENTS.md, docs/product-technical-gap-baseline.md
숫자 토큰 경계, 정수·소수 지수 처리, 브라우저 렌더링과 Storybook 경계 검증 결과를 기록했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to a9bcb

This documentation update leaves one Markdown formatting warning in the PR reference text. It has no runtime impact, but should be corrected to keep documentation lint-clean.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 런타임 귀속 수정과 커버리지 증거 기록이라는 주요 문서 변경을 정확히 설명합니다.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/gap-baseline-20260908

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae added documentation Improvements or additions to documentation priority: low labels Sep 8, 2026 — with ChatGPT Codex Connector

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for faad61903b1f1bf51ad734788f38c42fc731eabe.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Repository file: AGENTS.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Repository file: AGENTS.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Docs: product-technical-gap-baseline.md"]
  S2 --> I2["operator or user guidance"]
  I2 --> R2["Review risk: Docs: product-technical-gap-baseline.md"]
  R2 --> V2["docs review"]
Loading

@opencode-agent

opencode-agent Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

Copy link
Copy Markdown
Contributor Author

Exact-head faad61903 Tests run 34177270021 is terminal GREEN (22m49s) + Frontend GREEN. OpenCode CHANGES_REQUESTED is the org review gate (noema-review / opencode-review failed; model pool exhausted), not a product defect in this docs overlay. Do not treat that as independent APPROVE, and do not merge without independent APPROVE. The overlay correctly refuses to claim the all-page 20 ms target from /healthz/HTML probes.

@seonghobae seonghobae changed the title docs: correct runtime latency attribution and record CPU pressure docs: correct runtime attribution and record coverage evidence Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Current stack authority: parent #983 moved to a91e3724978e95f0902b3e77df91f50f7baf3599 for the post-body CodeQL repair. This branch was immediately converged without force as ordinary two-parent commit 9de1f021bd7c47b0c8d67b87b58ac6920a9f7a01, preserving its AGENTS.md and gap-baseline delta over the new parent tree. Descendant #992 was subsequently converged to d757aeab29fbd1a415edaa16b1842f0b7c8b5024. Predecessor validation receipts do not transfer.

seonghobae added a commit that referenced this pull request Sep 16, 2026
Adopt #983 exact e825c25 as a second parent without rewriting the documentation lane. The resulting tree preserves #984's existing delta and inherits the parent's post-body continuation/test repair.

Signed-off-by: Codex <codex@localhost>
seonghobae added a commit that referenced this pull request Sep 22, 2026
Adopt #984 exact d62c6e8 as a second parent without rewriting the documentation-hygiene delta. The resulting tree preserves #992 and inherits #983's post-body continuation/test repair through #984.

Signed-off-by: Codex <codex@localhost>
Adopt #983 exact 04329f7 as a second parent while preserving the documentation lane and inheriting the focused Space-key coverage regression.

Signed-off-by: Codex <codex@localhost>
seonghobae added a commit that referenced this pull request Sep 22, 2026
Adopt #984 exact bb4d5e0 as a second parent while preserving the documentation-hygiene delta and inheriting #983's focused Space-key coverage regression.

Signed-off-by: Codex <codex@localhost>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation priority: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant