fix(a11y): include leftover-pair evidence in button names

[seonghobae]

Current authority — 2026-09-21

Issue #976 remains the owner. This PR is the single LineageWeave source lane for LeftoverPairList evidence-in-accessible-name behavior and rendered browser acceptance.

• base/parent: feat(reports): preserve grouping comparison axis-singular delta for serialized successor #830 bebd77c03e5beae469f42361c20bccc80787ebb5
• exact head: 9dbb28706a3418ef0f9500873e9e7d7417961ef3
• last source-bearing repair: bce09c145b979e348d3db3ecad01246ff2d20ed9
• state: open / Draft / mechanically mergeable; exact ancestry remains ahead-only with behind_by=0
• predecessor browser/selector head: c614d683414b0af1af006c96ed53169ab5b21ee2
• duplicate-evidence RED → fix: 2a9696b25ce2423ebfff48217ea2e0a31ee3630f → 57c60f622b0cbda0a746a99d3af9dd98b50c679b
• non-finite residual disclosure RED → fix: 5dd4a63bb007c27c23b26e5c3895f8fa9e6abe52 → d162aaf307108fbbbda807c2dc4c0c74f33eda7a
• docs(gaps): refresh exact-head product evidence #1041 documentation merge / post-merge convergence: 73e0b59c06c1181538390fb32d79ef0c4091994b → 7d052532bde0000cb96cdd57957ff20806aa5c31
• ADR-lineage RED → fix: ff8adc587a5166c39a2d81450ab60ee602f3c9e5 → 724614e4d769986471fc5192285cf5d558c64ab5
• rank-zero accessible-evidence RED → fix: 7b6ff5bc16beb9c2ae91961bc753fb10ff3d7a89 → bce09c145b979e348d3db3ecad01246ff2d20ed9
• live gap-baseline refresh: 9dbb28706a3418ef0f9500873e9e7d7417961ef3

Predecessor receipts do not transfer.

Single-writer and product contract

#1041's valid product finding is fully inherited here; #1041 is merged documentation history, not a second LeftoverPairList source writer. The action name starts with the exact rendered localized Closest leftover: / Farthest leftover: label, retains localized rich next-action guidance, announces each formatter-admitted persisted measurement once, omits non-finite evidence from the accessible name, and does not derive/clamp/synthesize R, Y/E, rank, U, shares, R̂, ξ/ζ, or d. Accepted ADR 0162 still requires non-finite persisted residual to remain visibly disclosed as R — while excluding that placeholder from the programmatic name. Dense/mobile behavior, 44px touch target, keyboard/focus, and pinned Storybook Chromium interaction path remain owned here. Canonical KO/EN/JA/ZH/VI/ES/DE/FR translation authority remains #929/#932.

Repair in this head

Fresh source review found a narrow but real omission in the duplicate-suppression logic. formatLeftoverMapRank(0) admits persisted rank 0 and the button visibly renders that badge, but the rank-only zero guidance string (LEFTOVER_RANK_ZERO_ACTION) explains that there is no leftover structure without literally naming rank 0. The implementation nevertheless marked rank as already consumed and suppressed the trailing rank 0 from the programmatic name. Rank-zero + observed/expected was not affected because that richer action explicitly says rank 0.

RED 7b6ff5bc... adds a focused rendered regression requiring rank-only zero to remain visible and be announced exactly once. Fix bce09c14... preserves the existing localized zero-rank guidance and only stops marking rank as consumed in the rank-only zero branch, so the existing formatter badge supplies rank 0 once. Non-zero rank still suppresses its duplicate because LEFTOVER_RANK_STRUCTURE_ACTION names the numeric rank. No translation key, psychometric value, or source-of-truth boundary changed.

Compare 724614e4... → bce09c14... is ahead 2 / behind 0 and changes only LeftoverPairList.rankZeroAccessibleName.test.tsx plus a 3-addition/1-deletion causal edit in LeftoverPairList.tsx.

The current exact head adds only docs/product-technical-gap-baseline.md on top of that source repair. Baseline commit 9dbb2870... removes stale #977 and authentication head claims, records the current #899 → #1118 → #1120 → #1117 authority chain, and avoids self-invalidating the #977 source claim by naming bce09c14... as the last source-bearing repair while leaving the live PR API/body authoritative for the exact mutable head. Compare bce09c14... → 9dbb2870... is ahead 1 / behind 0 and changes only the baseline.

The prior ADR-lineage repair remains inherited: RED ff8adc58... pins accepted ADR 0272–0280 in ADR 0049 and fix 724614e4... restores only those lost references while preserving the WCAG 2.2 SC 2.5.3 label-in-name repair.

Current acceptance state

No pull-request workflow receipt exists yet for exact 9dbb2870.... The last source-bearing head had only Devin Review and CodeRabbit success, which are not focused/frontend/full-suite/Storybook/Security/SAST/CodeQL acceptance and are not independent approval. The documentation-only head does not make predecessor evidence transferable.

Keep Draft and unmerged until one unchanged exact head has focused/frontend/full-suite + Storybook Chromium GREEN, applicable Security/SAST/CodeQL GREEN, no unresolved valid review finding, locale/font-fallback evidence where applicable, and qualifying independent approval. Do not wake the lane with a no-op commit, cycle Draft/Ready, transfer predecessor receipts, self-approve, force push, destructively rebase, weaken gates, copy psychometric logic, or create another LeftoverPairList source writer.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Two repair findings, preserving this PR's valid evidence-name delta rather than closing it.

1. Wrong serialized parent. Issue #976 explicitly requires this lane to start from the then-current serialized product parent after #829/#830 ancestry settles. This head is still based on the older #802 branch. Keep the PR Draft and reconstruct/retarget it after #830 is promoted; do not patch the stale parent in place or replay cumulative history.

2. WCAG 2.2 SC 2.5.3 Label in Name. The visible button label starts with the localized kindLabel (for example Closest leftover: …), while the explicit accessible name starts Open leftover closest pair: …. The visible label text therefore is not contained in the accessible name. W3C SC 2.5.3 requires the programmatic name to contain the text presented visually, and recommends putting that visible text at the start: https://www.w3.org/WAI/WCAG22/Understanding/label-in-name.html . When this lane is reconstructed on the current parent, use the exact visible label as the accessible-name prefix, then append the action/evidence context. Add a realistic regression that compares rendered visible text with the computed aria-label, while retaining the existing fail-closed handling for non-finite evidence metrics.

[seonghobae]

Current-head review after single-writer convergence: the duplicate accessible-evidence finding is source-repaired by 2a9696b2... → 57c60f62...; accepted ADR 0162 visual R — is restored by 5dd4a63b... → d162aaf3...; #1041's valid docs delta is fully inherited through normal merge 73e0b59c... and non-force post-merge convergence 7d052532.... No unresolved review thread remains. Exact-head Tests 35555913839 is Draft-skipped, so this is not approval or hosted GREEN; browser/full-suite/security and independent approval remain required.

[seonghobae]

Current-head review found a documentation-lineage regression introduced by the #1041 convergence. docs/adr/0049-leftover-pair-report-ui.md drops ADR 0272–0280 from its Amended by, Decision, and naming-reference sections, while the exact parent #830 retained them and the current product source still renders those persisted segment/pair facts. This is not stale history: accepted ADR 0272 explicitly says it amends ADR 0049, and the current helper/source continues to implement reconstruction/share/U/R/Y/E/rank evidence. Treat this as a repair finding, not a close reason. Add an executable regression that pins the accepted 0272–0280 amendment chain, then restore only the lost cross-references while preserving this PR's WCAG Label-in-Name/accessibility repair. No wholesale parent replay.

[seonghobae]

Current-head review found one additional source-level accessibility defect and it is repaired in this head. In the rank-only zero case, formatLeftoverMapRank(0) admits and visibly renders rank 0, but LEFTOVER_RANK_ZERO_ACTION does not literally contain that measurement. The duplicate-suppression set still marked rank as consumed, so the programmatic name omitted a formatter-admitted persisted value. RED 7b6ff5bc... reproduces that exact rendered case; fix bce09c14... preserves the existing localized zero-rank guidance and only leaves rank 0 unsuppressed in that branch. Rank-zero + Y/E remains unchanged because its richer action already names rank 0; non-zero rank remains deduplicated. Exact 724614e4... → bce09c14... is ahead 2 / behind 0 and limited to the focused regression plus a 3-addition/1-deletion component edit. No hosted acceptance receipt exists yet for this exact head, so this comment is not approval or GREEN.