fix(review): keep each refused comment's own GitHub 422 phrase by seonghobae · Pull Request #968 · ContextualWisdomLab/.github

seonghobae · 2026-08-13T07:34:15Z

Summary

Mixed one-at-a-time retries can 422 for different reasons. The overview still applied one shared error phrase to every refused path:line.

--record-refusal appends path:line<TAB>phrase from that comment's gh api stderr.
Receipts render each refused location with its own GitHub 422 phrase.
Includes fix(review): receipt only refused path:line after mixed 422 retry #967 so this branch can land independently.

#963/#964/#966/#967 remain MERGEABLE with auto-merge; they are blocked by the two-approval ruleset, not a current-head code fail.

Test plan

pytest tests/test_opencode_inline_comment_fallback.py tests/test_opencode_agent_contract.py — 52 passed, 100% on the helper
pytest tests — 989 passed, 100% statements/branches, interrogate 100%
Current-head required checks on this PR

When GitHub refuses inline review comments, the PR-level fallback now lists each sanitized current-head finding location instead of a generic sentence. Suggested diffs stay out of the body.

Rebuild the fallback from gh api stderr after a refused attach so the OpenCode overview keeps each trusted path:line next to the GitHub 422 phrase instead of a location-only list.

A single invalid path:line 422s the whole comments array. After that failure, split the payload and retry each comment so surviving hunks still attach; remaining failures keep the overview receipts.

The publisher moved that phrase out of the workflow YAML, so the exact-head path-policy harness failed looking in the old file.

When some one-at-a-time inline comments attach and others 422, the overview must list only the refused locations so attached hunks are not reported as failed.

Mixed one-at-a-time retries can fail for different reasons. Record path:line plus that comment's gh api error so the overview does not reuse one shared sentence for every refused hunk.

coderabbitai · 2026-08-13T07:34:26Z

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 83 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6963190d-8f84-4270-9bfb-ca3fe31e2984

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb06cd and a8b3594.

📒 Files selected for processing (10)

.github/workflows/opencode-review-dispatch.yml
AGENTS.md
CHANGELOG.md
docs/doctoring/review-inline-comment-422-fallback.md
scripts/ci/materialize_base_python_requirements.py
scripts/ci/opencode_inline_comment_fallback.py
scripts/ci/test_strix_quick_gate.sh
tests/test_materialize_base_python_requirements.py
tests/test_opencode_agent_contract.py
tests/test_opencode_inline_comment_fallback.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-13T07:34:31Z

@cwl-noema-review please review this current head. Each refused inline comment must keep its own GitHub 422 phrase next to path:line.

Keep per-comment 422 text next to path:line, but escape backticks and HTML metacharacters before they land in the review body. Simulate the Linux x86_64 trusted-uv installer host so the local suite stays at 100%.

seonghobae · 2026-08-13T08:06:20Z

@cwl-noema-review Please review this exact current head (000245c720f7). The head added escaped 422 phrases after the previous mention.

A bare 422 or GitHub issue #422 is not a review-write failure. Only HTTP 422, status code 422, Error code: 422, and Unprocessable Entity trigger the inline-comment 422 fallback.

A later one-at-a-time retry of the same path:line must keep that comment's GitHub 422 phrase instead of dropping it as a duplicate row.

seonghobae · 2026-08-13T10:44:27Z

@cwl-noema-review Please review this exact current head (e867d6f75a2a3ebdae3629cfe1e4e3a15bf83e89). Independent Noema APPROVE on this SHA is required. Do not wait on two-approval.

A batch 422 now retries at most 20 comments. Locations past that cap are recorded as deferred path:line rows instead of opening unbounded gh api writes.

Materialize a base Python lock only when every package line is an exact SHA-256 pin or a two-token relative -r/--requirement include of a candidate lock path. A lone --require-hashes directive, ./dotted paths, and -r other-hashes.txt no longer enter the trusted build context.

seonghobae · 2026-08-13T19:21:15Z

@cwl-noema-review exact current head df6ba012 — leftover increment kept; materialize accepts only bounded relative -r includes. Head moved. Independent Noema APPROVE on this SHA is required. Do not wait on two-approval. Reviewers remain edit: deny. NVIDIA_NIM_API_KEY only.

Leftover path:line receipts live in the overview HTML comment. Strip HTML metacharacters and suggestion fences so a leftover cannot close the comment or reopen an applyable GitHub suggestion block.

seonghobae · 2026-08-13T19:46:57Z

@cwl-noema-review exact current head 91c8f5c1 — leftover overview receipts now sanitize path and phrase (CWE-116). Head moved. Independent Noema APPROVE on this SHA is required. Reviewers remain edit: deny. NVIDIA_NIM_API_KEY only.

Reject leftover 422-fallback paths that contain -->, <!--, or a suggestion fence so a leftover cannot close the overview HTML comment or reopen an applyable GitHub suggestion block.

seonghobae added 6 commits August 13, 2026 15:59

fix(review): cite trusted path:line in GitHub 422 inline fallback

ab69188

When GitHub refuses inline review comments, the PR-level fallback now lists each sanitized current-head finding location instead of a generic sentence. Suggested diffs stay out of the body.

fix(review): persist 422 inline failures as overview receipts

e099c28

Rebuild the fallback from gh api stderr after a refused attach so the OpenCode overview keeps each trusted path:line next to the GitHub 422 phrase instead of a location-only list.

fix(review): retry inline comments one at a time after batch 422

d37885d

A single invalid path:line 422s the whole comments array. After that failure, split the payload and retry each comment so surviving hunks still attach; remaining failures keep the overview receipts.

test(review): pin 422 fallback sentence in the Python helper

154a33d

The publisher moved that phrase out of the workflow YAML, so the exact-head path-policy harness failed looking in the old file.

fix(review): receipt only refused path:line after mixed 422 retry

dc261ff

When some one-at-a-time inline comments attach and others 422, the overview must list only the refused locations so attached hunks are not reported as failed.

fix(review): keep each refused comment's own GitHub 422 phrase

94ee03d

Mixed one-at-a-time retries can fail for different reasons. Record path:line plus that comment's gh api error so the overview does not reuse one shared sentence for every refused hunk.

seonghobae enabled auto-merge (squash) August 13, 2026 07:34

seonghobae mentioned this pull request Aug 13, 2026

fix(review): cap inline retry at 20 and list attached path:line #970

Closed

3 tasks

fix(review): escape GitHub 422 phrases in overview receipts

000245c

Keep per-comment 422 text next to path:line, but escape backticks and HTML metacharacters before they land in the review body. Simulate the Linux x86_64 trusted-uv installer host so the local suite stays at 100%.

seonghobae mentioned this pull request Aug 13, 2026

fix(review): drop off-hunk inline comments before GitHub POST #971

Closed

3 tasks

This was referenced Aug 13, 2026

fix(review): turn surviving suggested diffs into GitHub suggestions #972

Closed

fix(review): set start_line on multi-line GitHub suggestions #973

Closed

fix(review): list applyable suggestion ranges in overview receipts #974

Closed

seonghobae added 2 commits August 13, 2026 19:30

fix(review): treat only sealed HTTP 422 tokens as unprocessable

20f3bcc

A bare 422 or GitHub issue #422 is not a review-write failure. Only HTTP 422, status code 422, Error code: 422, and Unprocessable Entity trigger the inline-comment 422 fallback.

fix(review): keep later comment's own 422 phrase at same path:line

e867d6f

A later one-at-a-time retry of the same path:line must keep that comment's GitHub 422 phrase instead of dropping it as a duplicate row.

seonghobae added 2 commits August 13, 2026 23:25

fix(review): cap inline retry at 20 and defer leftover rows

877b318

A batch 422 now retries at most 20 comments. Locations past that cap are recorded as deferred path:line rows instead of opening unbounded gh api writes.

fix(review): sanitize leftover overview receipt path and phrase

91c8f5c

Leftover path:line receipts live in the overview HTML comment. Strip HTML metacharacters and suggestion fences so a leftover cannot close the comment or reopen an applyable GitHub suggestion block.

fix(review): omit leftover overview paths with comment closers

a8b3594

Reject leftover 422-fallback paths that contain -->, <!--, or a suggestion fence so a leftover cannot close the overview HTML comment or reopen an applyable GitHub suggestion block.

seonghobae mentioned this pull request Aug 14, 2026

fix(review): strip leftover range interiors from posted suggestions #998

Draft

seonghobae closed this Aug 14, 2026

auto-merge was automatically disabled August 14, 2026 08:25
Pull request was closed

Navigation Menu

Uh oh!

fix(review): keep each refused comment's own GitHub 422 phrase - #968

fix(review): keep each refused comment's own GitHub 422 phrase#968
seonghobae wants to merge 13 commits into
mainfrom
fix/inline-comment-per-comment-422-phrases

seonghobae commented Aug 13, 2026

Uh oh!

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading

Review limit reached

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Aug 13, 2026

Summary

Test plan

Uh oh!

coderabbitai Bot commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

seonghobae commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Aug 13, 2026 •

edited

Loading