Skip to content

fix(semgrep): make the pinned image digest authoritative - #941

Open
seonghobae wants to merge 5 commits into
mainfrom
fix/semgrep-digest-single-source-20260812
Open

fix(semgrep): make the pinned image digest authoritative#941
seonghobae wants to merge 5 commits into
mainfrom
fix/semgrep-digest-single-source-20260812

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep the current Semgrep OSS 1.169.0 immutable image reference in one job-level SEMGREP_IMAGE variable;
  • validate that the value is a complete 64-hex SHA-256 manifest reference;
  • resolve that exact manifest before scanning and use the same value for docker run;
  • fail closed with an explicit error instead of allowing a partial local digest to surface as an ambiguous image-manifest failure.

The unchanged digest remains:

semgrep/semgrep@sha256:2b33f46ba66cf8cc2ad59ccfa7d22951fd00c632c38f1339e84ec8e6e641a942

Scan scope, severities, SARIF handling, credentials, permissions, metrics-off behavior, and the existing fail-closed Semgrep gate remain unchanged.

Exact-current-head verification

  • protected base: main@6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba;
  • exact current head: 5f51364418eb6e17300e771f9738d0580acad115;
  • changed surface: .github/workflows/sast-semgrep.yml only;
  • SAST Semgrep run 31598619582, job 94120163405: terminal success;
  • the new Verify pinned Semgrep manifest step completed successfully before the scan;
  • OSV-Scanner PR, Security Scan, Python Security, SBOM Generation, Secret Scan, and Scorecard are terminal-success for this head; CodeQL remains queued;
  • no stale predecessor-head check or skipped check will be treated as acceptance.

Merge only after every required current-head check, zero valid unresolved findings, and the required qualifying independent approvals pass.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 102 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a270a61-0114-49dd-9628-e94b91db3a12

📥 Commits

Reviewing files that changed from the base of the PR and between 5f51364 and 6015981.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/doctoring/semgrep-image-digest-single-source.md
  • tests/test_central_required_workflow_ruleset_audit.py
  • tests/test_materialize_base_python_requirements.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3477362b-b08e-4c07-ac8a-e0bb3d398a02

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb06cd and 5f51364.

📒 Files selected for processing (1)
  • .github/workflows/sast-semgrep.yml

📝 Walkthrough

Walkthrough

Semgrep 워크플로가 이미지 참조를 고정 SHA256 digest로 관리한다. 실행 전에 digest 형식과 Docker 매니페스트 존재 여부를 검증한다. 검증된 이미지 참조를 Semgrep 실행 단계에서 사용한다.

Changes

Semgrep 이미지 검증

Layer / File(s) Summary
이미지 digest 고정 및 실행 전 검증
.github/workflows/sast-semgrep.yml
SEMGREP_IMAGE에 고정 digest를 설정한다. 실행 전에 semgrep/semgrep@sha256:<64-hex-digest> 형식과 Docker 매니페스트를 검증한다. 검증된 환경 변수로 Semgrep을 실행한다.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 검증된 고정 Semgrep 이미지 digest를 사용하도록 변경한 주요 내용을 정확하고 간결하게 설명합니다.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/semgrep-digest-single-source-20260812

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Current-head verification record (2026-08-12):

  • head: 432497975d8e74822f853e095764ec5bcbcf29c3;
  • base: main at 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba;
  • changed surface: .github/workflows/sast-semgrep.yml only;
  • immutable Semgrep image reference is unchanged and now has one workflow source of truth.

At observation time, SAST Semgrep, Scorecard, Secret Scan, OSV-Scanner PR, Python Security, and SBOM Generation were running; Security Scan and CodeQL PR were queued; CodeRabbit was pending. No review or unresolved thread exists yet. Merge remains blocked until all exact-head required checks complete and qualifying independent approval is present.

Copy link
Copy Markdown
Contributor Author

Current-head verification record (2026-08-12 UTC):

  • head: 432497975d8e74822f853e095764ec5bcbcf29c3
  • base: 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba
  • central workflow now keeps the full immutable reference in one SEMGREP_IMAGE variable and uses it for both evidence and docker run;
  • image reference: semgrep/semgrep@sha256:2b33f46ba66cf8cc2ad59ccfa7d22951fd00c632c38f1339e84ec8e6e641a942;
  • the exact Semgrep command completed successfully under the workflow's existing rules, severity, exclusions, SARIF, and metrics-off conditions;
  • all eight hosted checks for this exact head are terminal-success and there are no unresolved review threads.

The earlier local partial-digest manifest failure is therefore addressed at the central source of truth. Merge remains pending current independent review and repository policy approval; no stale or synthetic approval is being used.

Copy link
Copy Markdown
Contributor Author

@opencode-agent review

Review exact current head 432497975d8e74822f853e095764ec5bcbcf29c3 against independently resolved live main 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba. Eight exact-head hosted workflows and the separate CodeRabbit status are terminal-success, with no unresolved review thread. Verify that one immutable Semgrep image reference is authoritative for both evidence and execution without weakening rules, severity, exclusions, SARIF, or metrics-off behavior. Automated judgment is not qualifying independent human approval or merge authorization.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review
@opencode-agent review
@cwl-noema-review review

Review exact current head 432497975d8e74822f853e095764ec5bcbcf29c3 only. The exact-head security and supply-chain workflows are terminal-success. Validate that one job-level SEMGREP_IMAGE immutable digest is the sole source used by both evidence and docker run, with scan scope, severity, SARIF, permissions, credentials, and fail-closed behavior unchanged. Review only; do not mutate, merge, release, or alter protections.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

head_expected='432497975d8e74822f853e095764ec5bcbcf29c3'
base_expected='6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba'

printf '%s\n' '== checked-out HEAD =='
git rev-parse HEAD
printf '%s\n' '== requested commits available =='
git cat-file -e "${head_expected}^{commit}"
git cat-file -e "${base_expected}^{commit}"

printf '%s\n' '== changed paths: requested base..head =='
git diff --name-status "$base_expected" "$head_expected"

printf '%s\n' '== workflow outline =='
ast-grep outline .github/workflows/sast-semgrep.yml --items all

printf '%s\n' '== exact workflow diff =='
git diff --no-ext-diff --unified=80 "$base_expected" "$head_expected" -- .github/workflows/sast-semgrep.yml

printf '%s\n' '== current workflow source, numbered =='
cat -n .github/workflows/sast-semgrep.yml

printf '%s\n' '== SEMGREP_IMAGE and image invocation references =='
rg -n -C 4 'SEMGREP_IMAGE|semgrep/semgrep|docker\s+run|--config=|--severity=|--exclude=|--sarif|--error|--metrics=off' \
  .github/workflows/sast-semgrep.yml

Length of output: 18513


🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo='ContextualWisdomLab/.github'
pr_number='941'
head_expected='432497975d8e74822f853e095764ec5bcbcf29c3'
base_expected='6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba'

printf '%s\n' '== PR refs =='
gh api "repos/${repo}/pulls/${pr_number}" \
  --jq '{head_sha: .head.sha, base_sha: .base.sha, state: .state, draft: .draft}'

printf '%s\n' '== check runs attached to the requested head =='
gh api --paginate "repos/${repo}/commits/${head_expected}/check-runs?per_page=100" \
  --jq '.check_runs[] | {name, status, conclusion, details_url, app: .app.slug}'

printf '%s\n' '== commit statuses attached to the requested head =='
gh api --paginate "repos/${repo}/commits/${head_expected}/status?per_page=100" \
  --jq '.statuses[] | {context, state, target_url, creator: .creator.login}'

printf '%s\n' '== PR reviews =='
gh api --paginate "repos/${repo}/pulls/${pr_number}/reviews?per_page=100" \
  --jq '.[] | {user: .user.login, state, commit_id, submitted_at}'

printf '%s\n' '== unresolved review threads =='
gh api graphql \
  -F owner='ContextualWisdomLab' \
  -F name='.github' \
  -F number="$pr_number" \
  -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes { isResolved isOutdated comments(first: 1) { nodes { author { login } body } } }
      }
    }
  }
}' \
  --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'

Length of output: 10858


@seonghobae No findings.

I reviewed only head 432497975d8e74822f853e095764ec5bcbcf29c3 against base 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba.

  • The diff changes only .github/workflows/sast-semgrep.yml.
  • Line 61 defines one job-level SEMGREP_IMAGE value with the required immutable digest.
  • Line 75 uses ${SEMGREP_IMAGE} for log evidence.
  • Line 81 uses ${SEMGREP_IMAGE} for docker run.
  • The scan configuration, severity filters, exclusions, SARIF handling, permissions, credential handling, and fail-closed gate logic are unchanged.
  • The exact-head Semgrep (multi-language SAST) check completed successfully.
  • GitHub reports no unresolved review threads.

I used the repository guidance that only results attached to the exact current head count as check evidence. Some attached checks are skipped or neutral; I did not treat them as successful evidence.


🧠 Learnings used
Learnt from: seonghobae
Repo: ContextualWisdomLab/.github PR: 0
File: :0-0
Timestamp: 2026-08-05T13:44:10.007Z
Learning: For PR `#782`, only successful checks associated with the exact current head are valid merge evidence. Do not treat queued, in-progress, cancelled, predecessor-head, temporary-workflow, or administrative-bypass results as passing evidence. Before a formal approval, verify that the direct security and supply-chain workflows, the permanent hourly NVIDIA NIM contract, current-head reviews, unresolved-thread checks, and an independent approval have completed successfully.

Learnt from: CR
Repo: ContextualWisdomLab/.github PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-07-29T06:47:25.581Z
Learning: Applies to opencode.jsonc : All reviewer agents in `opencode.jsonc` must keep `"edit": "deny"`; reviewers must never implement changes.
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor Author

@opencode-agent review
@cwl-noema-review review
@coderabbitai review

Review exact current head 432497975d8e74822f853e095764ec5bcbcf29c3 only. Validate the one-file central SAST change: the exact immutable Semgrep image reference is declared once in job-level SEMGREP_IMAGE and the identical value is used both for logged evidence and docker run; confirm the digest itself, scan scope, severities, SARIF handling, credentials, permissions, failure semantics, and merge authority are unchanged. All observed exact-head hosted checks are terminal-success and no review thread exists. Review only; do not mutate, merge, release, or bypass protection.

Copy link
Copy Markdown
Contributor Author

Exact-current-head review request for 432497975d8e74822f853e095764ec5bcbcf29c3 over protected main@6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba.

The bounded one-file repair keeps the Semgrep OSS 1.169.0 image digest unchanged and makes one job-level SEMGREP_IMAGE value authoritative for both evidence and execution. CodeQL PR, Python Security, Security Scan, OSV-Scanner PR, Secret Scan, Scorecard PR, SBOM Generation, and SAST Semgrep are terminal-success on this exact head; no review thread exists.

Review this unchanged head read-only. Do not update the branch, synthesize author approval, merge, release, or weaken protection.

@coderabbitai review
@opencode-agent review
@cwl-noema-review review
@strix review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo='ContextualWisdomLab/.github'
pr_number='941'
head_expected='432497975d8e74822f853e095764ec5bcbcf29c3'
base_expected='6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba'
workflow='.github/workflows/sast-semgrep.yml'

printf '%s\n' '== local refs and changed paths =='
test "$(git rev-parse HEAD)" = "$head_expected"
git cat-file -e "${base_expected}^{commit}"
git diff --name-status "$base_expected" "$head_expected"
printf '%s\n' '== exact workflow diff =='
git diff --no-ext-diff --unified=100 "$base_expected" "$head_expected" -- "$workflow"
printf '%s\n' '== workflow outline =='
ast-grep outline "$workflow" --items all
printf '%s\n' '== image references and scan controls =='
rg -n -C 5 'SEMGREP_IMAGE|semgrep/semgrep|docker\s+run|--config=|--severity=|--exclude=|--sarif|--error|--metrics=off|permissions:|SEMGREP_APP_TOKEN' "$workflow"

printf '%s\n' '== pull request refs =='
gh api "repos/${repo}/pulls/${pr_number}" \
  --jq '{head_sha: .head.sha, base_sha: .base.sha, state: .state, draft: .draft}'
printf '%s\n' '== check runs on requested head =='
gh api --paginate "repos/${repo}/commits/${head_expected}/check-runs?per_page=100" \
  --jq '.check_runs[] | {name, status, conclusion, app: .app.slug}'
printf '%s\n' '== commit statuses on requested head =='
gh api --paginate "repos/${repo}/commits/${head_expected}/status?per_page=100" \
  --jq '.statuses[] | {context, state, creator: .creator.login}'
printf '%s\n' '== reviews =='
gh api --paginate "repos/${repo}/pulls/${pr_number}/reviews?per_page=100" \
  --jq '.[] | {user: .user.login, state, commit_id, submitted_at}'
printf '%s\n' '== unresolved threads =='
gh api graphql \
  -F owner='ContextualWisdomLab' -F name='.github' -F number="$pr_number" \
  -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes { isResolved isOutdated comments(first: 1) { nodes { author { login } body } } }
      }
    }
  }
}' \
  --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'

Length of output: 16946


@seonghobae No findings.

I reviewed only head 432497975d8e74822f853e095764ec5bcbcf29c3 against base 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba.

  • The diff changes only .github/workflows/sast-semgrep.yml.
  • Line 61 declares SEMGREP_IMAGE once at the semgrep job level.
  • The value is the required immutable reference: semgrep/semgrep@sha256:2b33f46ba66cf8cc2ad59ccfa7d22951fd00c632c38f1339e84ec8e6e641a942.
  • Line 75 logs ${SEMGREP_IMAGE}.
  • Line 81 passes the same ${SEMGREP_IMAGE} value to docker run.
  • The Semgrep configuration, severity filters, exclusions, SARIF processing, permissions, credential handling, and fail-closed gate logic are unchanged.
  • The exact-head Semgrep (multi-language SAST) check succeeded. The direct trivy-fs, scorecard, osv-scan, gitleaks (secret scan), and generate-sbom checks also succeeded.
  • I did not treat neutral or skipped checks as passing evidence, consistent with the repository guidance.
  • GitHub reports no unresolved review threads.

GitHub returned no submitted reviews. Therefore, no independent approval is present in the retrieved review data. This review does not grant merge authority.


🧠 Learnings used
Learnt from: seonghobae
Repo: ContextualWisdomLab/.github PR: 0
File: :0-0
Timestamp: 2026-08-05T13:44:10.007Z
Learning: For PR `#782`, only successful checks associated with the exact current head are valid merge evidence. Do not treat queued, in-progress, cancelled, predecessor-head, temporary-workflow, or administrative-bypass results as passing evidence. Before a formal approval, verify that the direct security and supply-chain workflows, the permanent hourly NVIDIA NIM contract, current-head reviews, unresolved-thread checks, and an independent approval have completed successfully.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo='ContextualWisdomLab/.github'
pr_number='941'
head='432497975d8e74822f853e095764ec5bcbcf29c3'
base='6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba'

echo '== Local commit and changed-path verification =='
printf 'checked_out_head='; git rev-parse HEAD
git cat-file -e "${head}^{commit}"
git cat-file -e "${base}^{commit}"
git diff --name-status "$base" "$head"

echo '== Workflow diff =='
git diff --no-ext-diff --unified=100 "$base" "$head" -- .github/workflows/sast-semgrep.yml

echo '== Relevant workflow lines at requested head =='
git show "${head}:.github/workflows/sast-semgrep.yml" |
  nl -ba |
  grep -E -C 5 'SEMGREP_IMAGE|semgrep/semgrep|docker run|--config=|--severity=|--exclude=|--sarif|--error|--metrics=off|permissions:|contents:|security-events:|SEMGREP_APP_TOKEN'

echo '== Pull request refs =='
gh api "repos/${repo}/pulls/${pr_number}" \
  --jq '{head: .head.sha, base: .base.sha, state, draft}'

echo '== Check runs for requested head =='
gh api --paginate "repos/${repo}/commits/${head}/check-runs?per_page=100" \
  --jq '.check_runs[] | {name, status, conclusion, app: .app.slug}'

echo '== Commit statuses for requested head =='
gh api --paginate "repos/${repo}/commits/${head}/status?per_page=100" \
  --jq '.statuses[] | {context, state, creator: .creator.login}'

echo '== Reviews =='
gh api --paginate "repos/${repo}/pulls/${pr_number}/reviews?per_page=100" \
  --jq '.[] | {user: .user.login, state, commit_id, submitted_at}'

echo '== Unresolved review threads =='
gh api graphql \
  -F owner='ContextualWisdomLab' \
  -F name='.github' \
  -F number="$pr_number" \
  -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          isResolved
          isOutdated
          comments(first: 1) { nodes { author { login } body } }
        }
      }
    }
  }
}' \
  --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'

Length of output: 10166


🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo='ContextualWisdomLab/.github'
pr_number='941'
head='432497975d8e74822f853e095764ec5bcbcf29c3'

echo '== Relevant workflow lines at requested head =='
git show "${head}:.github/workflows/sast-semgrep.yml" |
  cat -n |
  grep -E -C 5 'SEMGREP_IMAGE|semgrep/semgrep|docker run|--config=|--severity=|--exclude=|--sarif|--error|--metrics=off|permissions:|contents:|security-events:|SEMGREP_APP_TOKEN'

echo '== Pull request refs =='
gh api "repos/${repo}/pulls/${pr_number}" \
  --jq '{head: .head.sha, base: .base.sha, state, draft}'

echo '== Check runs for requested head =='
gh api --paginate "repos/${repo}/commits/${head}/check-runs?per_page=100" \
  --jq '.check_runs[] | {name, status, conclusion, app: .app.slug}'

echo '== Commit statuses for requested head =='
gh api --paginate "repos/${repo}/commits/${head}/status?per_page=100" \
  --jq '.statuses[] | {context, state, creator: .creator.login}'

echo '== Reviews =='
gh api --paginate "repos/${repo}/pulls/${pr_number}/reviews?per_page=100" \
  --jq '.[] | {user: .user.login, state, commit_id, submitted_at}'

echo '== Unresolved review threads =='
gh api graphql \
  -F owner='ContextualWisdomLab' \
  -F name='.github' \
  -F number="$pr_number" \
  -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          isResolved
          isOutdated
          comments(first: 1) { nodes { author { login } body } }
        }
      }
    }
  }
}' \
  --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'

Length of output: 9034


@seonghobae No findings.

I reviewed only 432497975d8e74822f853e095764ec5bcbcf29c3 against 6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba.

  • The diff changes only .github/workflows/sast-semgrep.yml.
  • Line 61 defines the full immutable digest once in job-level SEMGREP_IMAGE.
  • Line 75 uses ${SEMGREP_IMAGE} for evidence logging.
  • Line 81 uses the identical ${SEMGREP_IMAGE} value for docker run.
  • The digest is semgrep/semgrep@sha256:2b33f46ba66cf8cc2ad59ccfa7d22951fd00c632c38f1339e84ec8e6e641a942.
  • Scan scope, severity filters, exclusions, SARIF processing, permissions, credential persistence, and fail-closed behavior are unchanged.
  • The requested head and base still match PR #941.
  • The relevant exact-head checks are completed successfully.
  • I did not count skipped or neutral checks as successful evidence.
  • GitHub reports no unresolved review threads.

GitHub returned no pull-request reviews. Therefore, this review does not establish an independent approval or merge authorization.

I used the repository guidance that only successful checks on the exact current head count as merge evidence.


🧠 Learnings used
Learnt from: seonghobae
Repo: ContextualWisdomLab/.github PR: 0
File: :0-0
Timestamp: 2026-08-05T13:44:10.007Z
Learning: For PR `#782`, only successful checks associated with the exact current head are valid merge evidence. Do not treat queued, in-progress, cancelled, predecessor-head, temporary-workflow, or administrative-bypass results as passing evidence. Before a formal approval, verify that the direct security and supply-chain workflows, the permanent hourly NVIDIA NIM contract, current-head reviews, unresolved-thread checks, and an independent approval have completed successfully.

You are interacting with an AI system.

@seonghobae
seonghobae enabled auto-merge (squash) August 12, 2026 10:45

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-current-head source review for 432497975d8e74822f853e095764ec5bcbcf29c3 against protected main@6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba.

The complete one-file diff moves the already-pinned immutable Semgrep manifest reference into one job-level SEMGREP_IMAGE value and uses that exact value for both log evidence and docker run. The digest, scanner version, configuration, severities, exclusions, SARIF handling, metrics policy, permissions, credentials, and fail-closed --error behavior are unchanged. All eight directly triggered exact-head security and supply-chain workflows, including the modified SAST Semgrep workflow itself, are terminal-success and no inline thread exists.

A qualifying independent reviewer must submit formal approval on this unchanged head. Do not update the branch, change the image digest, weaken scanner arguments, synthesize author approval, or bypass protection.

Copy link
Copy Markdown
Contributor Author

Exact-current-head automated review request for 432497975d8e74822f853e095764ec5bcbcf29c3. The bounded one-file refactor retains the identical immutable Semgrep digest and scan semantics; all eight directly triggered workflows are terminal-success and no thread exists. Review read-only without updating the branch or weakening SAST policy.

@coderabbitai review
@opencode-agent review
@cwl-noema-review review
@strix review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@seonghobae have exceeded the limit for the number of chat messages per hour. Please wait 26 minutes and 15 seconds before sending another message.

@opencode-agent
opencode-agent Bot disabled auto-merge August 12, 2026 12:12

Copy link
Copy Markdown
Contributor Author

Exact-current-head source review request for 5f51364418eb6e17300e771f9738d0580acad115 against protected main@6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba.

Check that the job-level immutable Semgrep reference is complete, the preflight resolves the exact manifest, and the scan uses that same reference without changing existing rules, severities, exclusions, SARIF, permissions, credentials, or fail-closed behavior. Review read-only; no digest/tag weakening or merge bypass.

@opencode-agent review
@cwl-noema-review review
@strix review

Keep Semgrep OSS on a single SEMGREP_IMAGE digest, contract-test that
the hex pin appears once, and document SLSA/NIST 800-190 pinning.
@seonghobae

Copy link
Copy Markdown
Contributor Author

Reviewed. Added single-digest contract, CHANGELOG, and APA 7th doctoring (NIST SP 800-190, SLSA 1.0). Local suite 977 passed x2, coverage 100%. Auto-merge armed.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 24ca6081e4704ca176ca02015cbbf27e07fbf832.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: sast-semgrep.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow: sast-semgrep.yml"]
  R1 --> V1["actionlint plus required checks"]
  Evidence --> S2["Changed file: CHANGELOG.md"]
  S2 --> I2["repository behavior"]
  I2 --> R2["Review risk: Changed file: CHANGELOG.md"]
  R2 --> V2["required checks"]
  Evidence --> S3["Docs: semgrep-image-digest-single-source.md"]
  S3 --> I3["operator or user guidance"]
  I3 --> R3["Review risk: Docs: semgrep-image-digest-single-source.md"]
  R3 --> V3["docs review"]
  Evidence --> S4["Test (2 files)"]
  S4 --> I4["regression suite"]
  I4 --> R4["Review risk: Test (2 files)"]
  R4 --> V4["targeted test run"]
Loading

@opencode-agent

opencode-agent Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 8fabd327773eb5346f307ffdaa633b2e9f026c9a
  • Workflow run: 31753662932
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 8fabd327773eb5346f307ffdaa633b2e9f026c9a.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: sast-semgrep.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow: sast-semgrep.yml"]
  R1 --> V1["actionlint plus required checks"]
  Evidence --> S2["Changed file (2 files)"]
  S2 --> I2["repository behavior"]
  I2 --> R2["Review risk: Changed file (2 files)"]
  R2 --> V2["required checks"]
  Evidence --> S3["Docs: semgrep-image-digest-single-source.md"]
  S3 --> I3["operator or user guidance"]
  I3 --> R3["Review risk: Docs: semgrep-image-digest-single-source.md"]
  R3 --> V3["docs review"]
  Evidence --> S4["CI script: materialize_base_python_requirements.py"]
  S4 --> I4["review and security gate shell path"]
  I4 --> R4["Review risk: CI script: materialize_base_python_requirements.py"]
  R4 --> V4["bash -n plus Strix self-test"]
  Evidence --> S5["Test (2 files)"]
  S5 --> I5["regression suite"]
  I5 --> R5["Review risk: Test (2 files)"]
  R5 --> V5["targeted test run"]
Loading

@opencode-agent
opencode-agent Bot disabled auto-merge August 13, 2026 08:53
Materialize a base Python lock only when every package line is an exact
SHA-256 pin or a two-token relative -r/--requirement include of a
candidate lock path. A lone --require-hashes directive, ./dotted paths,
and -r other-hashes.txt no longer enter the trusted build context.
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 15:38

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode could not approve from deterministic current-head evidence because GitHub Checks have failed.

Findings

1. HIGH Current-head GitHub Checks - Fix failed required checks before approval

  • Problem: Failed same-head checks remain for 8fabd327773eb5346f307ffdaa633b2e9f026c9a.
  • Root cause: The model-unavailable evidence fallback is allowed only when peer GitHub Checks are complete and clean.
  • Fix: Read and fix the failed check logs below, then rerun the current-head checks.
  • Regression test: Keep the model-unavailable fallback gated on an empty failed-check rollup.

Failed checks:

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: sast-semgrep.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow: sast-semgrep.yml"]
  R1 --> V1["actionlint plus required checks"]
  Evidence --> S2["Changed file (2 files)"]
  S2 --> I2["repository behavior"]
  I2 --> R2["Review risk: Changed file (2 files)"]
  R2 --> V2["required checks"]
  Evidence --> S3["Docs: semgrep-image-digest-single-source.md"]
  S3 --> I3["operator or user guidance"]
  I3 --> R3["Review risk: Docs: semgrep-image-digest-single-source.md"]
  R3 --> V3["docs review"]
  Evidence --> S4["CI script: materialize_base_python_requirements.py"]
  S4 --> I4["review and security gate shell path"]
  I4 --> R4["Review risk: CI script: materialize_base_python_requirements.py"]
  R4 --> V4["bash -n plus Strix self-test"]
  Evidence --> S5["Test (2 files)"]
  S5 --> I5["regression suite"]
  I5 --> R5["Review risk: Test (2 files)"]
  R5 --> V5["targeted test run"]
Loading

@opencode-agent
opencode-agent Bot disabled auto-merge August 14, 2026 01:29
@seonghobae
seonghobae marked this pull request as draft August 14, 2026 09:04

Copy link
Copy Markdown
Contributor Author

Returned to Draft because the exact current tree contradicts the body’s “Semgrep workflow only” scope.

The valid repair is bounded: one job-level immutable SEMGREP_IMAGE, exact full SHA-256 manifest validation/resolution, and reuse of that same value for the scan. Head 8fabd327773eb5346f307ffdaa633b2e9f026c9a additionally changes materialize_base_python_requirements.py, its tests, central ruleset tests, AGENTS, doctoring, and changelog.

Rebuild from protected main retaining only sast-semgrep.yml, the focused digest/ruleset regression, directly attributable doctoring/changelog evidence, and no materializer changes. Update the stale exact-head/check section, then reacquire exact-head Semgrep/CodeQL/security/SBOM and independent-review evidence.

@seonghobae
seonghobae marked this pull request as ready for review August 14, 2026 13:56

Copy link
Copy Markdown
Contributor Author

@coderabbitai review
@opencode-agent review
@cwl-noema-review review
@strix review

Review only exact current head 6015981514956977ebf18e74f3441b3bc560a679 against live protected main@6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba. I removed the unrelated trusted-uv production delta by restoring the exact Semgrep immutable-manifest authority tree as a new descendant. The current diff is five files and preserves one job-level complete SHA-256 image reference, explicit manifest resolution before scan, the same immutable value for docker run, and fail-closed incomplete refs without changing scan scope, severities, permissions, credentials, metrics, or SARIF semantics. No review thread exists. Exact-head checks are regenerating; nonterminal evidence is not acceptance. Review read-only; do not mutate source, synthesize approval, weaken Semgrep/SLSA controls, or merge.

@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 13:56
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

repo='ContextualWisdomLab/.github'
pr_number='941'
head='6015981514956977ebf18e74f3441b3bc560a679'
base='6eb06cdd08c79a06f7b390069d4ffa49e2eb7dba'
workflow='.github/workflows/sast-semgrep.yml'

printf '%s\n' '== Local commit verification =='
printf 'checked_out_head='
git rev-parse HEAD
git cat-file -e "${head}^{commit}"
git cat-file -e "${base}^{commit}"

printf '%s\n' '== Changed files =='
git diff --name-status "$base" "$head"

printf '%s\n' '== Changed-file diff summary =='
git diff --stat "$base" "$head"

printf '%s\n' '== Full exact-head diff =='
git diff --no-ext-diff --unified=100 "$base" "$head"

printf '%s\n' '== Semgrep workflow structure =='
ast-grep outline "$workflow" --items all

printf '%s\n' '== Semgrep controls at exact head =='
git show "${head}:${workflow}" | nl -ba | \
  grep -E -C 6 'SEMGREP_IMAGE|semgrep/semgrep|docker manifest inspect|docker run|--config=|--severity=|--exclude=|--sarif|--error|--metrics=off|permissions:|SEMGREP_APP_TOKEN' || true

printf '%s\n' '== PR refs =='
gh api "repos/${repo}/pulls/${pr_number}" \
  --jq '{head_sha: .head.sha, base_sha: .base.sha, state, draft}'

printf '%s\n' '== Check runs at requested head =='
gh api --paginate "repos/${repo}/commits/${head}/check-runs?per_page=100" \
  --jq '.check_runs[] | {name, status, conclusion, app: .app.slug}'

printf '%s\n' '== Commit statuses at requested head =='
gh api --paginate "repos/${repo}/commits/${head}/status?per_page=100" \
  --jq '.statuses[] | {context, state, creator: .creator.login}'

printf '%s\n' '== Pull-request reviews =='
gh api --paginate "repos/${repo}/pulls/${pr_number}/reviews?per_page=100" \
  --jq '.[] | {user: .user.login, state, commit_id, submitted_at}'

printf '%s\n' '== Unresolved review threads =='
gh api graphql \
  -F owner='ContextualWisdomLab' \
  -F name='.github' \
  -F number="$pr_number" \
  -f query='
query($owner: String!, $name: String!, $number: Int!) {
  repository(owner: $owner, name: $name) {
    pullRequest(number: $number) {
      reviewThreads(first: 100) {
        nodes {
          isResolved
          isOutdated
          path
          line
          comments(first: 1) { nodes { author { login } body } }
        }
      }
    }
  }
}' \
  --jq '[.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false)]'

Length of output: 43341


@seonghobae Review result: one scope finding.

  • .github/workflows/sast-semgrep.yml has one job-level SEMGREP_IMAGE.
  • The value is the required full immutable digest.
  • The preflight validates the full digest format and runs docker manifest inspect.
  • The evidence log and docker run use the same ${SEMGREP_IMAGE} value.
  • The displayed workflow diff leaves scan configuration, severities, exclusions, SARIF handling, permissions, credentials, metrics, and Semgrep gate behavior unchanged.

Finding — PR scope is still broader than the bounded Semgrep repair.

tests/test_materialize_base_python_requirements.py changes trusted-uv installer test setup. This does not change production materializer code, but it is unrelated to the Semgrep image-reference contract. Remove this test-only delta, or split it into a separate PR with its own purpose and evidence.

The requested head and base match PR #941. No unresolved review thread exists. Exact-head checks are still queued or in progress, and several prior attempts are cancelled. I do not treat those results as successful evidence. No approval targets the requested head in the retrieved review data.

You are interacting with an AI system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant