fix(coverage): discover hash-pinned requirements lock files - #1157
fix(coverage): discover hash-pinned requirements lock files#1157seonghobae wants to merge 2 commits into
Conversation
|
@opencode-agent review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Changesrequirements 잠금 파일 후보 확장
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change broadens coverage-materializer discovery to include hash-pinned lock files and adds a focused regression test; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current-head verification for |
|
@opencode-agent Review exact current head |
|
@opencode-agent review exact current head f0823bb against base c47bee5, including the candidate-lock naming boundary and regression tests. |
4ff27bf to
666153a
Compare
|
@opencode-agent Review exact current head 666153a against main@2cce96f8. Rebased the lock-discovery change onto current main; requirements*.lock and existing requirements*.txt discovery remain content/hash gated. Verified: 43 focused tests passed, compileall, interrogate, and git diff --check. |
|
@opencode-agent review exact head |
|
@opencode-agent Review current exact head |
|
@opencode-agent Review the current exact head for the trusted Python lock-materializer repair. Verify |
|
@opencode-agent review this exact current HEAD. Use the current commit SHA, current Checks, and current diff; do not reuse prior approvals or prior-head evidence. |
|
Independent current-head verification for |
Root cause
The trusted base Python coverage materializer only recognized
requirements.lockandrequirements*.txt. Repositories usingrequirements-dev.lockwere therefore measured without their async test plugin; pg-erd-cloud #931 recorded 133 async test failures and coverage evidence failed.Change
requirements*.lockalongside existing hash-pinned.txtcandidatesVerification
python -m pytest -q tests/test_materialize_base_python_requirements.py(43 passed)ruff check scripts/ci/materialize_base_python_requirements.py tests/test_materialize_base_python_requirements.pygit diff --checkCurrent branch head:
f0823bb.Summary by CodeRabbit
개선 사항
requirements-dev.lock과 같은 다양한 잠금 파일을 요구사항 파일로 인식하도록 지원 범위를 확장했습니다.테스트