Skip to content

feat(automation): run pg-erd-cloud hourly NVIDIA NIM review repair - #1076

Open
seonghobae wants to merge 7 commits into
mainfrom
feat/pg-erd-cloud-hourly-nvidia-nim-review-repair
Open

feat(automation): run pg-erd-cloud hourly NVIDIA NIM review repair#1076
seonghobae wants to merge 7 commits into
mainfrom
feat/pg-erd-cloud-hourly-nvidia-nim-review-repair

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Buyer-perceivable gap

Hourly NVIDIA NIM review repair never scanned ContextualWisdomLab/pg-erd-cloud. Live ERD pull requests such as ContextualWisdomLab/pg-erd-cloud#916 (control-character insertion), #918, and #919 target protected main and stalled while Clearfolio, DiskSage, and fast-mlsirm received heartbeats.

Change

  • Thin scheduled caller at minute 13, base_branch: main, one dispatch, two-hour same-head retry.
  • Job-scoped id-token: write so the reusable scheduler can mint the OpenCode App fallback from GitHub OIDC.
  • Maps only PR_REVIEW_MERGE_TOKEN and OPENCODE_APPROVE_TOKEN. Never NVIDIA_NIM_API_KEY on the caller. Never COPILOT_GITHUB_TOKEN.
  • Independent pull_request / push / compileall path contracts.
  • Local 2× pytest + coverage + interrogate at 100% on this head.

Do not self-approve. Merge remains subject to two-approval + last-pusher ruleset. GitHub review/Checks wait is not a blocker.

Refs ContextualWisdomLab/pg-erd-cloud#916, ContextualWisdomLab/pg-erd-cloud#918, and ContextualWisdomLab/pg-erd-cloud#919.


Open in Devin Review

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 427aed78-1b0b-4d94-a434-c708e0448f63


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 17, 2026 02:41
@seonghobae
seonghobae force-pushed the feat/pg-erd-cloud-hourly-nvidia-nim-review-repair branch from 9f47dcc to 159858f Compare August 19, 2026 09:58
@seonghobae

Copy link
Copy Markdown
Contributor Author

Rebased onto current main 9e9f59f3; resolved shared hourly-contract conflicts while preserving pg-erd-cloud paths. Caller tests passed (6 passed); actionlint passed on both changed workflows; diff check passed. Project #1 is In Progress.

@seonghobae seonghobae moved this from Todo to In Progress in naruon Platform Roadmap Aug 19, 2026
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head repair update (2026-08-19 KST):

  • Root cause fixed: the PR had duplicated existing hourly quality paths, duplicated compileall entries, duplicated docs/doctoring/hourly-nvidia-nim-autofix.md, and a duplicated git diff --check; the live quality job reported five contract-test failures caused by those duplicates.
  • Patch: removed only those duplicate entries; retained the new pg-erd-cloud workflow, test, and doctoring paths.
  • Verification: full suite 1222 passed, 16 subtests passed; branch coverage 100% (438 statements / 154 branches); Interrogate 100%; compileall and git diff --check passed.
  • New exact head: 3eab87b2c74972a0ab24f3164ee1a242de1118f6.

The prior failed checks are stale for the old head. I am rechecking the new current-head checks; no merge or approval is being synthesized.

@seonghobae
seonghobae force-pushed the feat/pg-erd-cloud-hourly-nvidia-nim-review-repair branch from 3eab87b to 901901b Compare August 19, 2026 14:55
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head repair: rebased the pg-erd-cloud hourly caller onto main bbedc1a. Exact head: 901901b. Removed redundant cross-repository quality-workflow paths introduced by this PR; retained only the pg-erd-cloud scope. Focused caller plus affected duplicate-path regressions: 14 passed; actionlint and git diff --check passed. Protected hosted checks remain; no bypass used.

@opencode-agent
opencode-agent Bot disabled auto-merge August 19, 2026 20:48

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 901901bb36b097c005a6c2248c99c9fe8ae493e6.

  • Head SHA: 901901bb36b097c005a6c2248c99c9fe8ae493e6

  • Workflow run: 32291195450

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow (2 files)"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V1["actionlint plus required checks"]
  Evidence --> S2["Changed file (3 files)"]
  S2 --> I2["repository behavior"]
  I2 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V2["required checks"]
  Evidence --> S3["Docs: pg-erd-cloud-hourly-review-caller.md"]
  S3 --> I3["operator or user guidance"]
  I3 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V3["docs review"]
  Evidence --> S4["Test: test_pg_erd_cloud_hourly_review_caller.py"]
  S4 --> I4["regression suite"]
  I4 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V4["targeted test run"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 901901bb36b097c005a6c2248c99c9fe8ae493e6
  • Workflow run: 32291195450
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 901901bb36b097c005a6c2248c99c9fe8ae493e6.

  • Head SHA: 901901bb36b097c005a6c2248c99c9fe8ae493e6

  • Workflow run: 32291195450

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow (2 files)"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V1["actionlint plus required checks"]
  Evidence --> S2["Changed file (3 files)"]
  S2 --> I2["repository behavior"]
  I2 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V2["required checks"]
  Evidence --> S3["Docs: pg-erd-cloud-hourly-review-caller.md"]
  S3 --> I3["operator or user guidance"]
  I3 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V3["docs review"]
  Evidence --> S4["Test: test_pg_erd_cloud_hourly_review_caller.py"]
  S4 --> I4["regression suite"]
  I4 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V4["targeted test run"]
Loading

Merge Conflict Guidance

  • Current merge state: DIRTY
  • Base branch: main
  • Head branch: feat/pg-erd-cloud-hourly-nvidia-nim-review-repair
  • Fix direction: merge or rebase origin/main into feat/pg-erd-cloud-hourly-nvidia-nim-review-repair, resolve conflict markers in the changed files, rerun the focused checks, then push the same branch.
  • Repair commands:
gh pr checkout 1076 --repo ContextualWisdomLab/.github
git fetch origin main
git merge --no-ff origin/main  # or: git rebase origin/main
git status --short
# resolve files, then git add <resolved-files>
# merge path: git commit
# rebase path: git rebase --continue
git push origin HEAD:feat/pg-erd-cloud-hourly-nvidia-nim-review-repair
# rebase path only: git push --force-with-lease origin HEAD:feat/pg-erd-cloud-hourly-nvidia-nim-review-repair

@seonghobae
seonghobae force-pushed the feat/pg-erd-cloud-hourly-nvidia-nim-review-repair branch from 901901b to a1bd088 Compare August 20, 2026 01:21
@seonghobae

Copy link
Copy Markdown
Contributor Author

Rebased onto current origin/main c47bee5 and preserved the existing hourly caller path set plus the pg-erd-cloud documentation/changelog entry.

Current HEAD: a1bd088

Validation on this HEAD:

  • pytest -q tests/test_pg_erd_cloud_hourly_review_caller.py: 6 passed
  • actionlint: caller and hourly dispatcher passed
  • compileall and git diff --check passed

@OpenCode review this exact HEAD after the rebase.

@seonghobae
seonghobae force-pushed the feat/pg-erd-cloud-hourly-nvidia-nim-review-repair branch from a1bd088 to 3eb4514 Compare August 20, 2026 04:44
@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review the exact current head $head_oid against protected base 2cce96f. Rebased this hourly caller onto current main; contract tests, changed-workflow actionlint, and diff --check were run on the exact rebased source. The caller keeps explicit target identity, bounded dispatch/retry, OIDC/approved secret scope, and no COPILOT token forwarding. Treat predecessor reviews/checks as historical and do not approve from queued or status-only evidence.

@seonghobae
seonghobae dismissed opencode-agent[bot]’s stale review August 20, 2026 09:41

Dismiss stale review: review commit 901901b is not current PR head 3eb4514; current-head review is required.

Add a thin minute-13 caller for ContextualWisdomLab/pg-erd-cloud on
protected main. The caller maps only established scheduler credentials,
grants job-scoped OIDC, and leaves NVIDIA_NIM_API_KEY on the reusable
worker.
@opencode-agent
opencode-agent Bot force-pushed the feat/pg-erd-cloud-hourly-nvidia-nim-review-repair branch from 3eb4514 to 049b0b9 Compare August 20, 2026 10:55
devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Validated exact head 6daf546.

Addressed both current review findings:

  • restored the complete nonnest2 paragraph before the standalone pg-erd-cloud section in ARCHITECTURE.md;
  • collapsed the duplicate Product hourly callers bullet in CLAUDE.md.

Verification on this head:

  • python3 -m pytest -q tests/test_pg_erd_cloud_hourly_review_caller.py: 6 passed
  • git diff --check: passed

The PR remains subject to independent approvals and terminal protected Checks; no bypass or self-approval was used.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Review disposition

The two latest Devin observations were verified as informational: minute 13 is unique, and the caller inputs/secrets match the reusable scheduler contract. No code change was required. Both threads are resolved; current-head Checks and qualifying independent approvals remain required before a normal merge.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant