Skip to content

fix(opencode): execute asyncio helper on hash-locked quality CI - #1059

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/bc-9e1d5dcb-88b1-4dd4-94c0-56d3bf28b33b-de81
Draft

fix(opencode): execute asyncio helper on hash-locked quality CI#1059
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/bc-9e1d5dcb-88b1-4dd4-94c0-56d3bf28b33b-de81

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Next action

Review this successor of #819, then merge it instead of the unread-helper head. After protected main absorbs the pin, rerun coverage on an affected async consumer such as ContextualWisdomLab/pg-erd-cloud and keep that consumer issue open until marked coroutines collect.

Buyer-visible gap this closes

#819 already hash-pins pytest-asyncio==1.4.0 so the coverage image can execute pytest.mark.asyncio without rewriting the hashed review-dispatch blob. The helper that imports pytest_asyncio was not executed after lock install, so an unread script could claim the runtime was present.

This head keeps that pin and:

  • runs scripts/ci/ensure_opencode_asyncio_toolchain.sh after the quality job installs the hash lock
  • collects a marked coroutine the same way a downstream buyer suite does
  • records the quality-CI execution path and APA 7th sources in docs/doctoring/opencode-asyncio-test-runtime.md

Merge gate

Do not self-approve. Require exact-head checks and a qualifying non-author review. Do not edit opencode-review-dispatch.yml to carry the import.

Open in Web View Automation 

seonghobae and others added 2 commits August 17, 2026 01:46
Add hash-pinned pytest-asyncio and a fail-closed import helper so marked
asyncio tests can run in the coverage sandbox without rewriting the
review-agent dispatch blob.
Keep the coverage plugin pin off the hashed review-dispatch blob, but run
the fail-closed import helper after the quality job installs the lock and
collect a marked coroutine the same way a downstream buyer suite does.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next action

Do not merge #1059 as the landing vehicle.

The quality-CI helper execution and marked-coroutine contract are the right increment over #819. This head still edits root AGENTS.md, ARCHITECTURE.md, and CLAUDE.md, which open #896 already owns. Merging both will collide the control-plane documentation graph.

Use #1060. That head keeps the lock pin, runs the helper after the quality-job lock install, collects a marked buyer-style coroutine, and leaves the three root ADRs on protected main. Do not merge #819, #1059, and #1060 together. Do not self-approve. Do not open a fourth asyncio-toolchain PR unless #1060 regresses the lock pin, the quality-CI helper step, or the marked coroutine.

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

Comment thread AGENTS.md

Materialize accepts only exact SHA-256 pins or a bounded relative `-r` include (no `.`/`..`); a lone `--require-hashes` directive is not trust evidence. See [`docs/doctoring/hourly-nvidia-nim-autofix.md`](docs/doctoring/hourly-nvidia-nim-autofix.md).
Conflict-scope roots fail closed when the immediate parent directory is a symbolic link.
Coverage sandbox asyncio execution is pinned through `requirements-opencode-review-ci.txt` and `scripts/ci/ensure_opencode_asyncio_toolchain.sh`; quality CI must run that helper after the hash-lock install. Do not rewrite hashed `opencode-review-dispatch.yml` for that import.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this root ADR edit. #896 already owns AGENTS.md. Record the asyncio boundary in docs/doctoring/opencode-asyncio-test-runtime.md only, as #1060 does.

Comment thread ARCHITECTURE.md
## Coverage asyncio toolchain

The hash-pinned OpenCode review lock includes `pytest-asyncio==1.4.0`.
`scripts/ci/ensure_opencode_asyncio_toolchain.sh` fail-closed imports that

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This root architecture hunk collides with #896. Keep the mermaid and helper-after-lock-install path in doctoring. Prefer #1060, which has the quality-CI execution without this ADR overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants