Repository navigation
fix: the live verifier removes its unsafe test tool and names what it lacks - #99
Merged
Merged
Conversation
… lacks If ToolGate wrongly accepted verify-invalid-post, cleanup left it active (hunt toolgate-5 F3); it is now removed before and after every run. The tools and approval method the run needs from the owner's install are checked before anything is created, and a missing one is named instead of a bare StopIteration (F4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt toolgate-5 F3 and F4 (toolgate/scripts/verify_v2.py, the manual live-stack check).
verify-invalid-postis one of the run's temporary objects now, so it is deleted before the run and in the cleanup. Before, a ToolGate that wrongly accepted it kept an auto-authorized POST tool active.memorygate-contextandgithub-repos-countand the verification method "Home approval adapter". If any is missing, it stops before creating anything and names each missing object. Before, it failed midway with a bare StopIteration or an unrelated billing message. The docstring lists them. Making the verifier create these objects itself is a larger change and is left out.Tests (toolgate/tests/test_verify_v2_lockdown.py, the real main() against httpx.MockTransport): a missing install is named and nothing is created; a wrongly accepted unsafe tool is deleted in cleanup. Both fail on main. Local: 4 passed, ruff ok, types ok.