Repository navigation
fix: the 600-line check measures .jsx, .css, shell and shebang scripts - #98
Merged
Merged
Conversation
The gate dashboard's .jsx files, its .css and suffix-less scripts such as toolgate/cli/toolgate were never measured (hunt toolgate-5 F15). A last line without a final newline now counts too (F16).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt toolgate-5 F15 and F16.
SUFFIXESnow also covers .jsx, .cjs, .css and .sh. Tracked files without a suffix are measured when they start with#!(toolgate/cli/toolgate, sandbox/conker-install). Every tracked file in the repo passes today; the largest .jsx file has 180 lines.splitlines, so a 601-line file without a final newline no longer reads as 600.Tests (toolgate/tests/test_guard_scripts.py): 4 new file kinds, a shebang script (while a large LICENSE file stays ignored), and a missing final newline. All 6 fail on main. Local: 19 passed,
check_file_sizes.pyok, ruff ok.