Repository navigation
fix: every pending Inbox card can be rejected or dismissed - #97
Merged
Merged
Conversation
Rejecting or dismissing grants nothing, so it no longer depends on the card being reviewable or its origin being intact. A card whose arguments, origin or publication cannot be shown used to stay in the Inbox for good (hunt toolgate-2 F14). Approving still needs a reviewable card with an intact origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt toolgate-2 F14. The owner channel allowed reject/dismiss only for unavailable reasons None, expired, unsupported_subject and publication_unavailable, and
decide_requestchecked the verification origin before any decision. A card witharguments_unavailable,invalid_publication,invalid_actionorinvalid_origincould be neither approved nor closed, and stayed in the Inbox for good when it had no expiry.Now a no (rejected or dismissed) closes any pending card. A yes still needs
reviewableand an intact origin, anddecide_requeststill checks origin and expiry for approval.Tests (tests/test_owner_channel.py): withheld arguments, tampered origin and a legacy malformed binding are each still refused on approve (409) and now close on reject/dismiss. 12 of them fail on main.
Local: owner channel 21 passed; the 21 approval/request test files: 275 passed, 1 failed (test_process_death_after_effect_leaves_durable_unknown, which fails the same way on main on this PC because its subprocess cannot import toolgate). ruff ok, types ok.