Repository navigation
fix(drill): the stale-decision mutant changes behaviour instead of crashing - #94
Merged
Merged
Conversation
…ashing Its replacement called control_plane.get from approvals.py, which does not import it, so the test failed on NameError and the drill printed "Caught" without proving that a stale read is detected (toolgate-5 F1). The mutant now reads the row outside the write transaction, and the drill fails as BROKEN MUTANT whenever a mutant's run shows NameError, ImportError or SyntaxError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt finding toolgate-5 F1 (re-verified on main, mutation_check.py:96): the "stale decision overwrites consumption" mutant's replacement called
get("request", ...)inside toolgate/core/approvals.py, which imports only_conn, _now, _row. The mutant raised NameError, the test failed for that reason, and the drill printed "Caught". It proved nothing abouttest_late_decision_cannot_restore_a_consumed_token.Change:
BEGIN IMMEDIATEwrite transaction, then decides on it.BROKEN MUTANTand fails when a mutant's test output contains NameError, ImportError, SyntaxError or IndentationError, so a crash can no longer pass as a catch.Evidence: the full drill ran locally, exit 0. "Caught: stale decision overwrites consumption" now comes from the behaviour, and no mutant is reported broken. Two tests in
test_mutation_check.py(a crashing mutant is reported broken; the stale mutant reads the row itself) fail on main and pass here. Ruff ok.