Repository navigation
fix(workflows): $last only as a whole reference; required inputs cannot be null - #93
Merged
Merged
Conversation
…ot be null
Any string starting with "$last" ("$lastname", "$last week") was replaced by the previous
step's result (toolgate-2 F1); now only "$last" and "$last.<path>" resolve. A required input
sent as null passed validation and skipped every type and bound check (toolgate-2 F6); it is now
reported as required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hunt findings, re-verified on main:
$lastwas treated as a reference, so a literal argument such as$lastnameor$last weekbecame the previous step's whole result. Only$lastand$last.<path>resolve now, matching how$args.and$vars.already work.{"x": null}for a required field passed, becausename in argsis true and None skipped every check. A required field that is null now gets "'x' is required". Optional fields may still be null.Tests:
toolgate/tests/test_workflow_values.py. Four cases fail on main (three$last...texts and the null required field); all seven pass here. Full local suite: 1641 passed, 43 skipped (Windows). Ruff ok.