Repository navigation
fix: filler words never shrink a research query to nothing - #103
Merged
Merged
Conversation
QUERY_STOP_WORDS drops words like email, software, tool, team and small, so a query such as "email software" made GitHub repositories and Discourse return [] with no request (reported as no matching results) and App Store catalog and Product Hunt refuse it (hunt toolgate-4 F4). topic_terms() keeps every word when all of them are filler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt toolgate-4 F4, the part that drops the owner's query.
QUERY_STOP_WORDSholds ordinary words: email, software, tool(s), team, company, small, manual, problem, spreadsheet, workflow. Before this change, a query made only of them:_github_repositoriesand_discoursereturned[]without any request, reported as "Search completed safely but found no matching results";_appstore_catalogand_producthuntrefused it.research_base.topic_terms()drops filler as before, but keeps all the words when every one is filler. The four sites use it; the others already fell back to the raw query.Not changed (design, recorded in VERDICTS): the rest of the business-pain tuning in the same finding, such as Stack Exchange's 2-term focus and fixed sites, Reddit's fixed subreddit text, and the App Store's negative-review filter and low-rated-first ranking. Making research general rather than pain-focused is a product call.
Tests (toolgate/tests/test_research_topic_terms.py): the helper, GitHub repositories sending
email software, and the App Store catalog acceptingsmall team tools. All fail on main. Local: research + tool settings 292 passed; ruff and types ok.