Skip to content

fix: GLM relay round 2 (port check, file-size line count) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeybe1kin merged 4 commits into from
Nov 3, 2026
Merged

fix: GLM relay round 2 (port check, file-size line count) #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d49804b
fix: Line count undercounts files without trailing newline
alexeybe1kin Nov 3, 2026
e807c09
fix: Non-numeric SYSTEMGATE_PORT crashes at startup with unhandled Va…
alexeybe1kin Nov 3, 2026
bcdc411
fix: sparse=True does not avoid per-container Docker inspect calls
alexeybe1kin Nov 3, 2026
6dbf9f6
review: keep sparse=True on the container list
alexeybe1kin Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/check_file_sizes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def main() -> int:
allowed = allowlist()
problems = []
for path in tracked_sources():
lines = Path(path).read_text(encoding="utf-8", errors="replace").count("\n")
text = Path(path).read_text(encoding="utf-8", errors="replace")
lines = len(text.splitlines())
ceiling = allowed.pop(path, None)
if ceiling is None and lines > LIMIT:
problems.append(f"{path}: {lines} lines, limit {LIMIT}. Split it by concern.")
Expand Down
17 changes: 16 additions & 1 deletion systemgate/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,28 @@ def _value(name: str, default: str = "") -> str:
return os.environ.get(name, default).strip()


class ConfigError(ValueError):
pass


def _port(name: str, default: str) -> int:
raw = _value(name, default)
try:
port = int(raw)
except ValueError:
raise ConfigError(f"invalid {name}: {raw!r} (expected integer 1-65535)") from None
if not 1 <= port <= 65535:
raise ConfigError(f"{name} out of range: {port} (expected 1-65535)")
return port


def get_settings() -> Settings:
root = Path(__file__).resolve().parents[1]
data_dir = Path(_value("SYSTEMGATE_DATA_DIR", str(root / "data"))).expanduser().resolve()
backup_root = Path(_value("SYSTEMGATE_BACKUP_ROOT", "/backups")).expanduser().resolve()
return Settings(
host=_value("SYSTEMGATE_HOST", "127.0.0.1"),
port=int(_value("SYSTEMGATE_PORT", "8040")),
port=_port("SYSTEMGATE_PORT", "8040"),
data_dir=data_dir,
admin_key=_value("SYSTEMGATE_ADMIN_KEY"),
backup_root=backup_root,
Expand Down
Loading