Repository navigation
fix: the classifier matches whole words; one feeling word fires one signal - #73
Open
alexeybe1kin wants to merge 5 commits into
Open
alexeybe1kin wants to merge 5 commits into
alexeybe1kin wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt findings memorygate-2 F25 (and F26, dead code).
The memory classifier counted substring hits:
watch, the top priority;phase;Phrases now match as whole words. A curly apostrophe counts as a straight one, so "can’t stop" typed on a phone matches.
"sad", "anxious", "stressed", "overwhelmed" and "right now" sat in two lists each, so one word fired two phase signals. A phase now has two independent signals, a feeling and a timeframe. So "sad and overwhelmed this week" is
medium, nothigh. Only the stored confidence label changes; nothing reads it for decisions.The unused
NEGATION_WORDSlist is removed.Tests:
tests/test_classifier.pygains inside-a-word, curly-apostrophe and "one word, one signal" cases. 9 of them fail on main; "constraint" is coverage only. 22 passed locally; ruff, types and sizes ok.