Repository navigation
fix: an observation cap below one no longer breaks observation create - #72
Open
alexeybe1kin wants to merge 5 commits into
Open
alexeybe1kin wants to merge 5 commits into
alexeybe1kin wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt findings memorygate-2 F50 and F19.
PUT /config/{agent}accepted anymax_observationsand any threshold. With a cap of 0 or less and no unconfirmed observation,enforce_budgetcalledmax()on an empty list, so every observation create answered 500.max_observations1..100000 and the thresholds 0..1, and answers 422 outside those ranges.flush, notcommit), so it is committed with the new observation or not at all.Tests: four new cases in
tests/test_observation_budget.py, all failing on main. Locally: budget, observation and config tests 30 passed; ruff, types and sizes ok.