Repository navigation
fix: source edits keep the ingest key; a disabled source takes no evidence - #68
Open
alexeybe1kin wants to merge 8 commits into
Open
alexeybe1kin wants to merge 8 commits into
alexeybe1kin wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hunt findings memorygate-1 F13 and F14.
POST /evidence/sourceswith new secrets replaced the whole secret map. That dropped theingest_keymade byrotate-ingest-key, so the listener was cut off. The ingest key is now kept; other secrets are replaced as before (and{}still means unchanged).POST /evidenceaccepted evidence for a disabled source. It is now refused with 409.last_ingested_atwas set to the event's ownoccurred_at, which can be years old or in the future. It is now the arrival time.Tests:
tests/test_evidence_source_updates.py, 2 tests, both failing on main. Locally: evidence and listener tests 44 passed; ruff and types ok.