Repository navigation
refactor(changelog): pass the range endpoints to buildChangelogRange as one object - #565
Merged
Merged
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
…as one object Splits the bounds, window test and sort order into small helpers, so no unit takes more than two parameters or exceeds McCabe 5. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/versioniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| composer | ✅ | ✅ 32/32 | |||
| npm | ❌ | ✅ 302/302 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 762/762 · 7 skipped (8 legs) | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-11-02 20:42 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildChangelogRangenow takes the installed and target version as one{ installed, target }object, and its bounds, window test and sort order live in three small helpers. Behaviour is unchanged; the one caller inApp.vueand the unit tests pass the object.SIG numbers (gate 122, five-star profile, against development 82474e1)
versioniq goes from 28/44 to 30/44 at 5-star and stays 36/44 at 4-star. Every touched unit is within the 5-star unit bounds (largest: 10 LOC, McCabe 5, 2 params). Gate 122 ratchet: 0 findings (1 inherited, App.vue:2079). Gate 123 against the #564 floor: 36 floored checks held.
Verification
src/utils/changelog.golden.spec.ts: 256 cases (4 version lists times 8 by 8 endpoints, 116 non-empty ranges), recorded on the old code in the first commit, plain re-run green on old and new.installed === targetcheck and> 0to>= 0on the direction both leave an empty window when the two compare equal, exactly as the old code did.npm run lint: exit 0, no new warnings. Hydra gates--scope-to-diff --base origin/development: exit 0.AI assisted (Claude Code); reviewed against the golden before opening.