Repository navigation
refactor(chat): split the unique conversation title into its lookups - #1237
Merged
rubenvdlinde merged 1 commit intoNov 2, 2026
Merged
Conversation
ensureUniqueTitle() keeps the lookup, the free-title return and its log lines; filtering the found titles by their prefix and finding the highest numeric suffix are their own methods. A golden recorded on the old code replays 200 generated conversation sets against the new code. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 2, 2026 03:42
Contributor
Quality Report — ConductionNL/hermiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-bundle-budget | ✅ | ||||
| composer | ✅ | ✅ 126/126 | |||
| npm | ❌ | ✅ 838/838 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 2908/2908 | ||||
| Newman | ✅ 15/15 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-02 06:11 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ConversationManagementHandler::ensureUniqueTitle()was one 62-line unit. It keeps the lookup, the early return for a free title and its two log lines. Two steps are now their own private methods, with 2 parameters each:titlesStartingWith()keeps the found titles that start with the base titlehighestTitleSuffix()finds the highest<base> (<n>)suffix, at least 1The separate
empty($existingTitles)return is gone becausein_array()on an empty list already returns the base title. The CyclomaticComplexity suppression is gone too.Behaviour
Unchanged.
ConversationUniqueTitleGoldenTestwas recorded on the old code. It generates 200 conversation sets (non-entities, missing or non-string titles, prefixed titles, suffixes such as(07),(x)and(5) more) and records the returned title, the lookup calls and the log lines. It passes on the old code and on the new code.Checks
^anchor, which only matters for a title that holds the base title twice.SIG (gate 122 reader, PHP)
Assisted-by: ClaudeCode:claude-opus-5-5