fix(pbs): derive a proposal's fork from its slot, not the JSON decode - #487
Open
JasonVranek wants to merge 1 commit into
Open
fix(pbs): derive a proposal's fork from its slot, not the JSON decode#487JasonVranek wants to merge 1 commit into
JasonVranek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue with the current [unreleased] SSZ code.
While testing on Kurtosis, prysm submitted a blinded block as JSON with
Eth-Consensus-Version: fulu. Our JSON decode path ignored that header (only the SSZ path was using it) and fell back to serde's untagged matching.SignedBlindedBeaconBlockis an untagged enum, so it takes the first variant that parses, and an Electra blinded block is field-identical to a Fulu one. So a Fulu block quietly decoded as Electra. We then read the fork straight off that decoded value and told the relayEth-Consensus-Version: electra. Helix checked the claimed fork against the slot and rejected the submission with "data for an unexpected fork was provided".So this PR just makes sure we handle the header + JSON case.
Nothing released is affected. This is just for upcoming the SSZ optimizations.