Fix error caused by modifying Flags.MAX_SPLASHES - #963
Open
HEIHUAa wants to merge 1 commit into
Open
Conversation
Raltyro
requested changes
Jul 26, 2026
Contributor
Author
|
If we want to change it to Math.min(Flags.MAX_SPLASHES, 7) without crashing, we'll have to dig into flixel.group to find the real issue. |
Member
|
Do you have the crash log? it would be helpful |
Contributor
Author
Wait a moment. |
Contributor
Author
This is the error pop-up. The crash occurs when the first splash effect is triggered.
|
Contributor
Author
|
At least judging from the code, I believe that |
Raltyro
added
type:help wanted
Member
|
can you confirm if this crash also happens in internal-merge? |
Contributor
Author
Yes, internal-merge still has this issue. 
|
Contributor
Author
I also tried the freshly built internal-merge, and the issue remains unchanged. |
Raltyro
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.