Promote deep-import exports to public API (GMT-1740, rebased onto beta) - #3415
Draft
dreamwasp wants to merge 52 commits into
Draft
Promote deep-import exports to public API (GMT-1740, rebased onto beta)#3415dreamwasp wants to merge 52 commits into
dreamwasp wants to merge 52 commits into
Conversation
Made-with: Cursor # Conflicts: # .eslintrc.js # package.json # yarn.lock
fixed linting errors re: connectedForm
|
View your CI Pipeline Execution ↗ for commit 737ca45 ☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 429c2e0 ☁️ Nx Cloud last updated this comment at |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cass-gmt-1473-beta, resolved against beta's own independent changes (React 19 ref-narrowing helpers,revert type widening,combobox attrs).Button(buttonProps),ButtonBase(component, with a JSDoc steering usage toward the styled Button variants),Markdownoverrides (createCodeBlockOverride,createInputOverride,createTagOverride,createVideoOverride,standardOverrides),PopoverContainer/types,Form/SelectDropdown/types,Tip/shared/types,Form/types(FormValues,BaseInputProps),Box/props(GridBoxProps),gamut-icons(IconStyleProps).deep-imports-verified-inventory.md§5 in base camp):Menu/elements'sList/ListProps/ListItem/ListItemProps/ListLink/ListLinkProps/ListButton→MenuList*(collided with the publicListcomponent), andForm/SelectDropdown/elements'sIconOptioncomponent →IconOptionComponent(collided with theIconOptiontype).Test plan
tsc --noEmitclean onpackages/gamutandpackages/gamut-iconsyarn jeston Menu, Form/SelectDropdown, ButtonBase, Button, Markdown, Box, Tip, PopoverContainer, gamut-icons — 18 suites / 281 tests passingMenu/elementsorSelectDropdown/elementsnames