Kl gmt 1704 gamut elevation beta - #3414
Draft
LinKCoding wants to merge 29 commits into
Draft
Conversation
…t child (#3411) * fix(Markdown): correct Details summary detection when summary is first child `summaryIndex === 0` was falsy, so a `<summary>` at child position 0 was never detected, falling back to the default "Details" label. The guard in `getStyledDetailChildren` also required `summaryIndex` to be truthy, so details blocks with no summary at all returned undefined instead of rendering the fallback. - Fix `hasSummary` to use `summaryIndex > -1` instead of `summaryIndex > 0` - Fix `getStyledDetailChildren` guard from `if (children && summaryIndex)` to `if (children)` so the fallback summary always renders - Add `summaryIndex !== undefined` checks before indexing into children Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: gamut package release plan * test(Markdown): add regression test for summary at first child index --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- project: gamut-kit 3.0.16 - project: gamut 72.5.3
|
View your CI Pipeline Execution ↗ for commit 55af6a8 ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cass-gmt-1607-publish #3414 +/- ##
=========================================================
+ Coverage 90.50% 90.94% +0.43%
=========================================================
Files 276 276
Lines 5793 5798 +5
Branches 1955 1962 +7
=========================================================
+ Hits 5243 5273 +30
+ Misses 541 516 -25
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…mut-elevation-beta
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a847f5c2810fa323eff9dc3--gamut-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs