Skip to content

fix: declare type-only example events as plain types - #435

Closed
GraemeF wants to merge 2 commits into
mainfrom
fix/unused-schema-lint
Closed

GraemeF wants to merge 2 commits into
mainfrom
fix/unused-schema-lint

Conversation

@GraemeF

@GraemeF GraemeF commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

typescript-eslint 8.71.2 changed no-unused-vars so that a value used only as a type is reported. Four places declared an example event as a schema constant and derived the type from it, but never used the schema at runtime: the event store test suite, two aggregates tests and the command processing example. They fail lint on Renovate's eslint update in #433.

Each example event is now a plain type. Neither package's exports or behaviour change. Once this merges, #433 passes lint with no change to its branch.

@GraemeF
GraemeF marked this pull request as ready for review October 19, 2026 05:59
@GraemeF GraemeF mentioned this pull request Oct 19, 2026
1 task
@GraemeF GraemeF changed the title fix(eventsourcing-store): declare the test suite's example event as a plain type fix: declare type-only example events as plain types Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

@GraemeF

GraemeF commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

Superseded. The same fix reached main through #433, which Renovate automerged with the fix commit on its branch.

@GraemeF GraemeF closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant