chore: sync upstream dubinc/dub to 2026-07-16 - #69
Conversation
- Sync upstream dubinc/dub at commit 1dfc9fe (2026-07-16) - Add CFA hostnames (app.fyi.codeforafrica.org, dub.dev.codeforafrica.org) - Make session cookie domain configurable via NEXTAUTH_COOKIE_DOMAIN env var - Keep existing CFA customizations (Resend config, disable signups, self-hosting docs)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The right approach @VinneyJ is:
This approach ensures 2nd PR is small enough to be human-reviewable. It's impossible for someone to review a 3000+ files PR hunting down for a few changes that were made by hand. Having said that, we're almost at the end of 2/3rd Sprint working on this so lets merge it (if all our tests, automated and manual, pass). |
|
Hey @kilemensi, thank you for the feedback. That makes a lot of sense. I'll make sure the next sync follows that PR approach you've recommended so it's easy to isolate and review. For now, the Vercel preview is failing because the database credentials changed (I created a new PlanetScale DB branch). I'm updating the env vars now once the db branch finishes to initialize and will retrigger the build. Once that's green, I'll ping you for a final check. |
|
Sync PR is up! Had to fix a few build issues along the way: stale DB credentials on the preview environment, a routing conflict from files upstream had restructured away but were still in our branch, and new marketplace tables from upstream that weren't in our PlanetScale dev schema yet. All resolved. Ready to promote to prod. |
|
The E2E failure on the sync PR is not something we introduced. Upstream removed the Needs a separate PR to update |
|
I am merging now @kilemensi |
If Anyways, the longer this PR stays open, the more questions I have. May be have a small demo (how everything is pulled/merged/setup with @nkasozi) and then lets merge and move on. |
|
Tested the full sync on staging at dub.dev.codeforafrica.org, and everything was good. Pushed the schema changes to the main DB to prepare for the merge, but that left production in a broken state. The currently deployed code still references columns that were dropped as part of the upstream sync (dublink, ssoEnabled, subscribed), so the build is now failing. PR #69 is the only code compatible with the current main DB schema. Merging it is the fix: #69. I will merge for now, then address the recommendation a bit later. |
Summary
dubinc/dubat commit1dfc9fe373(2026-07-16)developCFA-specific changes included
app.fyi.codeforafrica.organddub.dev.codeforafrica.orgtoAPP_HOSTNAMESso middleware routes them correctlyNEXTAUTH_COOKIE_DOMAINenv var (CFA uses.codeforafrica.org)RESEND_FROMandRESEND_REPLY_TOremain env-configurable/registerredirects to/loginReplaces
Replaces PR #66 which had the same changes but with a noisy commit history.
Test plan
/registerredirects to/loginapp.fyi.codeforafrica.org