Skip to content

Pool.release defined but not implemented #168

Open

Description

@larserik

The function release() is defined in the Pool class

release(options?: mysql.QueryOptions): Bluebird<void>;

But there is no release function in the implementation pool.js
https://github.com/CodeFoodPixels/node-promise-mysql/blob/7c075145cc981ae945ee612181e28b2c74f3e843/lib/pool.js

Is it a mistake to have it in the definition? Or is it missed to be implemented?

For example Visual Studio Code will give the release function as an autocomplete suggestion. But if you use it you will get the error TypeError: _a.release is not a function

Activity

  1. emilh91 commented on Dec 23, 2024

    @emilh91

    Hi @larserik - the readme states the following; not sure if this is relevant to your issue:

    Upgrading from v4 to v5
    The pool.releaseConnection has been removed, please use poolConnection.release instead.
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions