Skip to content

fix(predation): jaw-only carcasses, the goldens and the stability floor that go with it (main is red) - #144

Merged
CodeByBryant merged 1 commit into
mainfrom
fix/jaw-only-carcass-gates
Nov 13, 2026
Merged

CodeByBryant merged 1 commit into
mainfrom
fix/jaw-only-carcass-gates

Conversation

@CodeByBryant

Copy link
Copy Markdown
Owner

Summary

Main is red. #143 was merged with the Copilot bot's one-line change that makes carcasses jaw-only, but without the parts that make it pass. On the merge commit aed927b, Determinism failed on ubuntu shards 1 and 2 and windows shards 1 and 2: shard 2 is the 4 predation goldens (the entries predation-ecology-12k, -reflex-8k, -evolving-bodies-6k, -lush-4k move with jaw-only carcasses), shard 1 is the ecology-stability floor that seed 6 now violates. (The workflow-level conclusion reads "success"; the shard jobs are red.)

This PR is exactly the missing pieces, which were already on the #143 branch after the merge:

  • 4 goldens regenerated in the commit that causes them (the other 48 do not touch a carcass; with the old yields all 52 reproduced).
  • ecology-stability floor 15 to 8, measured: 12 held-out seeds (5-8, 33-40, 50,000 ticks, sampled every 1,000 after 10,000): means 37.7 to 77.2, minimum 10 (seed 6; the next lowest is 17), maximum 118, no world extinct. Means and ceiling hold; only the floor moved because herbivores lost the carrion they were eating (5 percent of intake). brain-long-run-1/-2, anatomy-long-run and ecology-stability-1 pass.
  • Tests with negatives: only a jaw bites or sees carrion; a mandible does neither; the old table is still expressible.
  • Docs and ADR 0026/0023 updated to say carcasses are the jaw's alone.

The measured cost of jaw-only carcasses (ADR 0026): population about 11 percent lower, carrion share of intake 5.3 to 0.7 percent, a jaw alive in 2 of 8 worlds at 100,000 ticks (1 of 8 before), one world with 21 of 29 creatures jaws.

Type of change

  • Feature
  • Bug fix
  • Refactor
  • Performance improvement
  • Tests
  • Documentation
  • Build/CI
  • Breaking change

Simulation impact

  • No simulation behavior changed
  • Changes organism behavior
  • Changes genetics or inheritance
  • Changes learning
  • Changes ecology or resources
  • Changes persistence or save compatibility
  • Changes determinism

Determinism

  • Uses the seeded random source
  • Does not use Math.random() in simulation code
  • Does not use wall-clock time for simulation behavior
  • Determinism tests were added or updated
  • Not applicable

No hash schema bump; no engine code changes in this PR (config default already on main).

Testing

Commands run:

golden suite on this branch: 52 of 52
vitest run tests/predation: 58 of 58; config 153 of 153; tsc test project clean; prettier clean
earlier on the identical code: ecology-stability-1, brain-long-run-1/-2, anatomy-long-run pass

Additional tests:

CI on this PR is the check for the other determinism files (species, replay, chunking, validity): they assert a run is the same stepped, chunked or in one go and cannot be affected by carcass yields; they timed out locally only when three shards ran at once.

Performance impact

  • No expected performance impact
  • Improves performance
  • May reduce performance
  • Benchmark included

Save compatibility

  • No save-format impact
  • Save format changed
  • Migration added
  • Existing saves tested

Screenshots or recordings

Not applicable.

Review notes


Generated by Claude Code

…hat go with it (ADR 0026)

PR #143 merged with the one-line carcass change from the Copilot bot but without
the parts that make it pass: 4 predation goldens regenerated, the ecology-stability
floor 15 to 8 (measured over 12 held-out seeds: means 37.7-77.2, minimum 10 on seed
6, maximum 118, none extinct), tests with negatives (only the jaw bites or sees
carrion, a mandible does neither, the old table is still expressible) and the doc
updates. Main's determinism shards 1 and 2 failed on both OSes at aed927b for exactly
this reason (stale goldens; seed 6 under the floor).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cn5qp4xBHxLnTrwReNXcf8
Copilot AI balanced review requested due to automatic review settings November 13, 2026 18:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@CodeByBryant
CodeByBryant merged commit bcc5c22 into main Nov 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants