feat: add manual release trigger - #71
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fcbc8-e3a0-75c0-96d5-80533eea7457 Co-authored-by: Amp <amp@ampcode.com>
Architecture review · analyzing…⏳ CodeBoarding is analyzing the architecture changes in this PR. This usually takes a few minutes. codeboarding-action · run 30891184024 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 246707b3f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: release | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| release-as: ${{ inputs.release_as || '' }} |
There was a problem hiding this comment.
When a manual run supplies release_as, googleapis/release-please-action@v4 does not declare or consume a release-as input; it is absent from the action's v4 input metadata. GitHub therefore reports this as an unexpected input and the action falls back to ordinary manifest/Conventional Commit detection, so the requested version can be silently ignored and the run may create no release PR or propose the wrong version. Use a supported release-please configuration or CLI mechanism to apply the forced version.
Useful? React with 👍 / 👎.
| on: | ||
| push: | ||
| branches: [main] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
When a maintainer selects a non-main branch in the workflow-dispatch branch picker, the action's omitted target-branch input defaults to the branch on which the workflow is running, as documented in the v4 action inputs. Repeated manual runs can therefore prepare and publish a release from a feature branch even though the existing automatic trigger is intentionally restricted to main; set target-branch: main or reject dispatches whose ref is not main.
Useful? React with 👍 / 👎.
1 participant
Summary
workflow_dispatchtrigger to the release-please workflowrelease_asversion to force a release PR when Conventional Commit detection cannot infer oneUsage
Open Actions → release-please → Run workflow and enter a version such as
1.10.0. Leave it empty to run normal Conventional Commit detection.Validation
git diff --check