Add privacy-safe configurable OpenTelemetry tracing - #24
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcc2fcfc1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "url.full", | ||
| "url.query", | ||
| "user_agent.original", |
There was a problem hiding this comment.
When an OTLP endpoint is configured and the server receives HTTP traffic, the pinned Starlette/ASGI instrumentation can emit the legacy http.target attribute containing the raw path and query string. This denylist removes http.url and the newer url.* fields but forwards http.target unchanged, so query parameters—including tokens or user-supplied text—can still reach the telemetry backend; add the legacy request-target key to the sanitizer and cover it in the privacy test.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80b77f5300
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Security exception: cryptography 50.0.0 fixes GHSA-g6cj-pr64-35w5 and was | ||
| # released inside the normal quarantine window. Keep the exception package- | ||
| # scoped so all unrelated dependencies remain subject to the seven-day delay. | ||
| exclude-newer-package = { cryptography = "2026-08-01T00:00:00Z" } |
There was a problem hiding this comment.
Remove this exception or retain cryptography 49.0.0 until the quarantine expires: this August 4 commit makes the lock select 50.0.0 even though uv.lock records its artifacts as uploaded on July 31, only about four days earlier. This directly bypasses the repository's mandatory seven-day waiting period for versioned dependencies.
AGENTS.md reference: AGENTS.md:L22-L27
Useful? React with 👍 / 👎.
| otlp_endpoint = os.environ.get( | ||
| "OTEL_EXPORTER_OTLP_TRACES_ENDPOINT" | ||
| ) or os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT") |
There was a problem hiding this comment.
When OTEL_EXPORTER_OTLP_TRACES_ENDPOINT contains URI credentials or a query-based access token, selecting it here causes the later info-level log to serialize the complete value as endpoint, exposing that credential in normal production logs. Log only a redacted destination such as scheme and host rather than the raw endpoint.
Useful? React with 👍 / 👎.
1 participant
What changed
FASTMCP_LOG_ENABLED=falseto avoid retaining rejected payloadsWhy
These two telemetry commits were created after OAuth PR #23 merged and were never published. This ports them onto the current
mainwithout changing the OAuth challenge or token-exchange behavior.Validation
uvx --from uv==0.11.28 uv sync --locked --extra testuvx --from uv==0.11.28 uv run python -m pytest src/tests/ -q— 200 passeduvx --from uv==0.11.28 uv run python smoke_test.py— 6 passed