Repository navigation
Docs: add dbt-clickhouse remote - #362
Merged
Merged
Conversation
|
🕵
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a545057. Configure here.
| // `{ "$ref": "./x.json" }` is replaced by the file; sibling keys (e.g. | ||
| // `{ "language": "es", "$ref": "./es/docs.json" }`) are kept on top. | ||
| const p = path.normalize(path.join(baseDir, o.$ref)); | ||
| if (!fs.existsSync(p) && isInOmittedRemote(p)) return null; |
There was a problem hiding this comment.
Omitted refs drop sidebar entries
Medium Severity
When a navigation $ref points into an omitted remote, resolveRefs returns null and the sidebar generator drops that entry. Omitted sourceRef remotes still become a production link, so preview builds lose the dbt group instead of keeping a path to production.
Reviewed by Cursor Bugbot for commit a545057. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClickHouse/dbt-clickhouseas a remote documentation source.docsdirectory at the existing dbt integration path.Validation
jq empty remotes.jsongit diff --check