Repository navigation
Conversation
The content panel is a flex column with a max height, and its items kept the default flex-shrink, so items taller than the 32px minimum shrank before the panel started to scroll. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ariser
force-pushed
the
nick/dropdown-item-no-shrink
branch
from
October 7, 2026 18:03
b31e74c to
15334da
Compare
🦋 Changeset detectedLatest commit: 15334da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ariser
marked this pull request as ready for review
October 7, 2026 18:05
DreaminDani
approved these changes
Oct 7, 2026
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-qjnfvxp6l-clickhouse.vercel.app Built from commit: |
Contributor
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dropdown.Itemnow hasflex-shrink: 0, so it keeps its full height when the menu is taller than the space available. The menu scrolls instead.display: flexfromGenericMenuPanel,flex-direction: columnfrom.dropdown-menu-content) withmax-height: var(--radix-dropdown-menu-content-available-height)andoverflow-y: auto. The items kept the defaultflex-shrink: 1, so items taller than one line (for example with a description) shrank toward their 32pxmin-heightbefore the panel started to scroll.Links and tickets
CUI-324. History: #535 (for #533, long lists) added
min-height: 32pxtoDropdown.Item"to make sure it does not get compressed". That was the same shrinking: the minimum only stops the items at 32px. This PR removes the cause.Good to know
Selectdoes not have this problem: its options sit inside a block element withoverflow: auto, and that element is the flex item, so the options are not flex items. Wrapping the Dropdown items in the same way was an alternative; this PR uses the smaller change.Tests
No unit test: this is layout, and jsdom does no layout. No new visual test case was added.
Checklist
Contribution
buildandbuild-storybookwork locallyAccessibility
Skipped: no markup, behavior or ARIA changed. One layout declaration was added.
Screenshots
TODO: before/after of a scrolling menu with multi-line items.
🤖 Generated with Claude Code