Repository navigation
fix(DateTimeRangePicker): preserve meridiem on Enter - #1245
fallintoplace wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 0786d31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thank you for contribution, @fallintoplace ! |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix reuses existing conversion logic, includes regression coverage, and has no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes DateTimeRangePicker so committing a time with Enter preserves the selected meridiem.
Changes:
- Reuses the existing time-change handler for Enter.
- Adds regression coverage for preserving
2:37 pm. - Includes a patch changeset.
Validation was limited to static review; tests and interactive accessibility checks were not run.
| File | Description |
|---|---|
| src/components/DatePicker/DateTimeRangePicker.tsx | Reuses meridiem-aware logic on Enter. |
| src/components/DatePicker/DateTimeRangePicker.test.tsx | Tests that Enter preserves PM. |
| .changeset/fix-datetime-range-picker-enter-meridiem.md | Documents the patch fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
Description
pm.handleTimeChangefor Enter.2:37 pmkeeps2:37 pm.Links and tickets
Good to know
Checklist
Contribution
buildandbuild-storybookwork locallyAccessibility
Screenshots