Repository navigation
fix(Grid): sort copied indexes numerically - #1244
fallintoplace wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 52bf71d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thank you for contribution, @fallintoplace ! |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix is correct, tested for both affected selection modes, and appropriately documented.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes Grid copy ordering so multi-digit row and column indexes are sorted numerically.
Changes:
- Adds numeric comparators for selected indexes.
- Adds regression tests for rows and columns.
- Adds a patch changeset.
| File | Description |
|---|---|
src/components/Grid/copyGridElements.ts |
Sorts copied indexes numerically. |
src/components/Grid/copyGridElements.test.tsx |
Tests numeric copy ordering. |
.changeset/fix-grid-copy-numeric-order.md |
Documents the consumer-visible fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
Description
10before2.[10, 2, 3]gives[2, 3, 10].Links and tickets
Good to know
Checklist
Contribution
buildandbuild-storybookwork locallyAccessibility
Screenshots